From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: quentin.schulz@theobroma-systems.com,
Chris Morgan <macromorgan@hotmail.com>,
Douglas Anderson <dianders@chromium.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org, heiko@sntech.de,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Quentin Schulz <foss+kernel@0leil.net>
Subject: Re: [PATCH] clk: rockchip: re-add rational best approximation algorithm to the fractional divider
Date: Mon, 31 Jan 2022 20:22:58 +0200 [thread overview]
Message-ID: <YfgpAu2fjxMZrzxe@smile.fi.intel.com> (raw)
In-Reply-To: <20220131163224.708002-1-quentin.schulz@theobroma-systems.com>
On Mon, Jan 31, 2022 at 05:32:24PM +0100, quentin.schulz@theobroma-systems.com wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Thanks for your report.
> In commit 4e7cf74fa3b2 ("clk: fractional-divider: Export approximation
> algorithm to the CCF users"), the code handling the rational best
> approximation algorithm was replaced by a call to the core
> clk_fractional_divider_general_approximation function which did the same
> thing back then.
>
> However, in commit 82f53f9ee577 ("clk: fractional-divider: Introduce
> POWER_OF_TWO_PS flag"), this common code was made conditional on
> CLK_FRAC_DIVIDER_POWER_OF_TWO_PS flag which was not added back to the
> rockchip clock driver.
>
> This broke the ltk050h3146w-a2 MIPI DSI display present on a PX30-based
> downstream board.
>
> Let's add the flag to the fractional divider flags so that the original
> and intended behavior is brought back to the rockchip clock drivers.
I believe this was the result of the discussion about 1000 in DRM code.
I Cc'ed this to the people from 64ec4912c51a ("drm/rockchip: Update crtc
fixup to account for fractional clk change").
> Fixes: 82f53f9ee577 ("clk: fractional-divider: Introduce POWER_OF_TWO_PS flag")
> Cc: stable@vger.kernel.org
> Cc: Quentin Schulz <foss+kernel@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
> drivers/clk/rockchip/clk.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index b7be7e11b0df..bb8a844309bf 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -180,6 +180,7 @@ static void rockchip_fractional_approximation(struct clk_hw *hw,
> unsigned long rate, unsigned long *parent_rate,
> unsigned long *m, unsigned long *n)
> {
> + struct clk_fractional_divider *fd = to_clk_fd(hw);
> unsigned long p_rate, p_parent_rate;
> struct clk_hw *p_parent;
>
> @@ -190,6 +191,8 @@ static void rockchip_fractional_approximation(struct clk_hw *hw,
> *parent_rate = p_parent_rate;
> }
>
> + fd->flags |= CLK_FRAC_DIVIDER_POWER_OF_TWO_PS;
> +
> clk_fractional_divider_general_approximation(hw, rate, parent_rate, m, n);
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-01-31 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:32 [PATCH] clk: rockchip: re-add rational best approximation algorithm to the fractional divider quentin.schulz
2022-01-31 18:22 ` Andy Shevchenko [this message]
2022-02-23 23:44 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfgpAu2fjxMZrzxe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dianders@chromium.org \
--cc=foss+kernel@0leil.net \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=mturquette@baylibre.com \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).