From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Shaik Sajida Bhanu <sbhanu@codeaurora.org>,
Matthias Kaehlcke <mka@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl
Date: Mon, 31 Jan 2022 18:33:17 -0600 [thread overview]
Message-ID: <Yfh/zXKrzC5zaxl/@builder.lan> (raw)
In-Reply-To: <CAD=FV=U4oma5qeoboczmKf6Qx7hpuwFbU-wi51p=owaKgZCQtg@mail.gmail.com>
On Mon 31 Jan 18:25 CST 2022, Doug Anderson wrote:
> Hi,
>
> On Mon, Jan 31, 2022 at 4:11 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 40cb414bc377..dc98a87e2871 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -616,6 +616,9 @@ qfprom: efuse@784000 {
> >
> > sdhc_1: sdhci@7c4000 {
> > compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&sdc1_clk>, <&sdc1_cmd>, <&sdc1_data>, <&sdc1_rclk>;
> > + pinctrl-1 = <&sdc1_clk_sleep>, <&sdc1_cmd_sleep>, <&sdc1_data_sleep>, <&sdc1_rclk_sleep>;
> > status = "disabled";
> >
> > reg = <0 0x007c4000 0 0x1000>,
> > @@ -2425,6 +2428,9 @@ apss_merge_funnel_in: endpoint {
> >
> > sdhc_2: sdhci@8804000 {
> > compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>;
> > + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>;
> > status = "disabled";
> >
> > reg = <0 0x08804000 0 0x1000>;
> > @@ -3943,81 +3949,76 @@ qup_uart15_rx: qup-uart15-rx {
> > function = "qup17";
> > };
> >
> > - sdc1_on: sdc1-on {
> > - clk {
> > - pins = "sdc1_clk";
> > - };
> >
> > - cmd {
> > - pins = "sdc1_cmd";
> > - };
> >
> > - data {
> > - pins = "sdc1_data";
> > - };
> > + sdc1_clk: sdc1-clk {
>
> Ugh. I just noticed that there are way too many blank lines here in
> the output. Happy to have this fixed when applying or I can post a v2.
>
I can fix that up as I apply it. Will let it sit for a few days to
attract reviews first though.
Regards,
Bjorn
next prev parent reply other threads:[~2022-02-01 0:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 0:10 [PATCH 0/5] arm64: dts: qcom: sc7x80: A smattering of misc dts cleanups Douglas Anderson
2022-02-01 0:10 ` [PATCH 1/5] arm64: dts: qcom: sc7180-trogdor: Add "-regulator" suffix to pp3300_hub Douglas Anderson
2022-02-01 17:57 ` Matthias Kaehlcke
2022-02-01 0:10 ` [PATCH 2/5] arm64: dts: qcom: sc7280-herobrine: Consistently add "-regulator" suffix Douglas Anderson
2022-02-01 17:58 ` Matthias Kaehlcke
2022-02-01 0:10 ` [PATCH 3/5] arm64: dts: qcom: sc7280: Properly sort sdc pinctrl lines Douglas Anderson
2022-02-01 18:02 ` Matthias Kaehlcke
2022-02-01 0:10 ` [PATCH 4/5] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl Douglas Anderson
2022-02-01 0:25 ` Doug Anderson
2022-02-01 0:33 ` Bjorn Andersson [this message]
2022-02-01 0:34 ` Doug Anderson
2022-02-02 21:28 ` Doug Anderson
2022-02-01 0:10 ` [PATCH 5/5] arm64: dts: qcom: sc7280-idp: No need for "input-enable" on sw_ctrl Douglas Anderson
2022-02-01 18:27 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfh/zXKrzC5zaxl/@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=sbhanu@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).