From: Tejun Heo <tj@kernel.org>
To: "yukuai (C)" <yukuai3@huawei.com>
Cc: axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH -next] blk-throttle: enable io throttle for root in cgroup v2
Date: Tue, 1 Feb 2022 07:20:32 -1000 [thread overview]
Message-ID: <Yflr4FzUTWsiLTC/@slm.duckdns.org> (raw)
In-Reply-To: <235b0757-d322-2b6e-3ab6-ecc8c82f8f1e@huawei.com>
Hello,
On Thu, Jan 27, 2022 at 10:36:38AM +0800, yukuai (C) wrote:
> In our case, the disk is provided by server, and such disk can be shared
> by multipul clients. Thus for the client side, the server is a higher
> level parent.
>
> Theoretically, limit the io from server for each client is feasible,
> however, the main reason we don't want to do this is the following
> shortcoming:
>
> client can still send io to server unlimited, we can just limit the
> amount of io that can complete from server, which might cause too much
> pressure on the server side.
I don't quite follow the "send io to server unlimited" part. Doesn't that
get limited by available number of requests? ie. if the server throttles,
the in-flight requests will take longer to complete which exhausts the
available requests and thus slows down the client. That's how it's supposed
to work on the local machine too.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-02-01 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 9:30 [PATCH -next] blk-throttle: enable io throttle for root in cgroup v2 Yu Kuai
2022-01-26 17:29 ` Tejun Heo
2022-01-27 2:36 ` yukuai (C)
2022-02-01 17:20 ` Tejun Heo [this message]
2022-02-08 1:38 ` yukuai (C)
2022-02-08 18:49 ` Tejun Heo
2022-02-09 1:22 ` yukuai (C)
2023-02-06 15:10 ` Michal Koutný
2022-02-09 3:14 ` Ming Lei
2023-02-05 15:55 ` Ofir Gal
2023-02-06 15:00 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yflr4FzUTWsiLTC/@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).