From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B82EC433FE for ; Thu, 17 Feb 2022 00:27:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbiBQA1M (ORCPT ); Wed, 16 Feb 2022 19:27:12 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbiBQA1I (ORCPT ); Wed, 16 Feb 2022 19:27:08 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1990124C2C for ; Wed, 16 Feb 2022 16:26:54 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id y18so3287611plb.11 for ; Wed, 16 Feb 2022 16:26:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YHx/xJYQk1JNIJZetMC/+JPrg4nbDjgeFqBB4S61lu8=; b=FleV49LY25DWgQdH1bP9FI3lP0QStIhDTqZTBx1u9XW6IY2AJf3/Qksv6w0huu50o/ LYZUfUJjgNlNspT/aWUQ6yDpYEtpoL2lujVHRrK0jBUwA53Rr9Ef+g/9QG94IHNuUf/N nAj435sc/2vmIBQu3ey/dbUf619TvAkCO76XQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YHx/xJYQk1JNIJZetMC/+JPrg4nbDjgeFqBB4S61lu8=; b=AkB728OQkzaRwEKY0VqArNEYK9BJwgyS3wFAhAzI7D33GPvSsSOdsHOmWkojQ2JsNv 5/faMTNZPKwIPeEBOPi606iRDo2wybsi+/Hg8OBbynobZ9mLTp4QnuoBfQupGuv6jDpw N4UGyv/2a0W/eol0y9jtB4ThLDCYlWarhXLmZybHlWpSiwzWk/fPpkfIg/XrfTBWmfTw WGDRerG31sVM6CyWLX1YGOeGUFJscZYriDpk6lGlkTSIbpYkbn6UqwYOtDuHHweMEzTJ E0WMR8eR6dVfYCS8UUdlx9nxJW0C2jyoMKXLn5OUiKf8bO2j0ySy3MoHo5hixo1wmvI2 RWzg== X-Gm-Message-State: AOAM530tLaMUjR6wGep2TniOGPq8iK8tFTJ2+w1F/RjQQvAjoT+a/txq BbDhPrrvB7m0KAFVVaMJtitwttGS2Fai4Q== X-Google-Smtp-Source: ABdhPJzXbnU2U9IqpTd6OXXwmzlx8TMIqYIEHM05tKeIUJ3OQEsB10xaAJq8vc0H0YKzSpHoAeOnSA== X-Received: by 2002:a17:90a:ab17:b0:1b9:b61a:aadb with SMTP id m23-20020a17090aab1700b001b9b61aaadbmr379604pjq.77.1645057614218; Wed, 16 Feb 2022 16:26:54 -0800 (PST) Received: from localhost ([2620:15c:202:201:20:e0d2:8c14:1e68]) by smtp.gmail.com with UTF8SMTPSA id f16sm48441853pfa.147.2022.02.16.16.26.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 16:26:53 -0800 (PST) Date: Wed, 16 Feb 2022 16:26:51 -0800 From: Matthias Kaehlcke To: Lukasz Luba Cc: Doug Anderson , LKML , Linux PM , amit daniel kachhap , Daniel Lezcano , Viresh Kumar , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Dietmar Eggemann , Pierre.Gondois@arm.com, Stephen Boyd , Rajendra Nayak , Bjorn Andersson Subject: Re: [PATCH 1/2] thermal: cooling: Check Energy Model type in cpufreq_cooling and devfreq_cooling Message-ID: References: <20220207073036.14901-2-lukasz.luba@arm.com> <4a7d4e94-1461-5bac-5798-29998af9793a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 10:43:34PM +0000, Lukasz Luba wrote: > > > On 2/16/22 10:13 PM, Matthias Kaehlcke wrote: > > On Wed, Feb 16, 2022 at 09:33:50AM -0800, Doug Anderson wrote: > > > Hi, > > > > > > On Wed, Feb 16, 2022 at 7:35 AM Lukasz Luba wrote: > > > > > > > > Hi Matthias, > > > > > > > > On 2/9/22 10:17 PM, Matthias Kaehlcke wrote: > > > > > On Wed, Feb 09, 2022 at 11:16:36AM +0000, Lukasz Luba wrote: > > > > > > > > > > > > > > > > > > On 2/8/22 5:25 PM, Matthias Kaehlcke wrote: > > > > > > > On Tue, Feb 08, 2022 at 09:32:28AM +0000, Lukasz Luba wrote: > > > > > > > > > > > > > > > > > > > > > > > > [snip] > > > > > > > > > > > > Could you point me to those devices please? > > > > > > > > > > > > > > arch/arm64/boot/dts/qcom/sc7180-trogdor-* > > > > > > > > > > > > > > Though as per above they shouldn't be impacted by your change, since the > > > > > > > CPUs always pretend to use milli-Watts. > > > > > > > > > > > > > > [skipped some questions/answers since sc7180 isn't actually impacted by > > > > > > > the change] > > > > > > > > > > > > Thank you Matthias. I will investigate your setup to get better > > > > > > understanding. > > > > > > > > > > Thanks! > > > > > > > > > > > > > I've checked those DT files and related code. > > > > As you already said, this patch is safe for them. > > > > So we can apply it IMO. > > > > > > > > > > > > -------------Off-topic------------------ > > > > Not in $subject comments: > > > > > > > > AFAICS based on two files which define thermal zones: > > > > sc7180-trogdor-homestar.dtsi > > > > sc7180-trogdor-coachz.dtsi > > > > > > > > only the 'big' cores are used as cooling devices in the > > > > 'skin_temp_thermal' - the CPU6 and CPU7. > > > > > > > > I assume you don't want to model at all the power usage > > > > from the Little cluster (which is quite big: 6 CPUs), do you? > > > > I can see that the Little CPUs have small dyn-power-coeff > > > > ~30% of the big and lower max freq, but still might be worth > > > > to add them to IPA. You might give them more 'weight', to > > > > make sure they receive more power during power split. > > > > In experiments we saw that including the little cores as cooling > > devices for 'skin_temp_thermal' didn't have a significant impact on > > thermals, so we left them out. > > > > > > You also don't have GPU cooling device in that thermal zone. > > > > Based on my experience if your GPU is a power hungry one, > > > > e.g. 2-4Watts, you might get better results when you model > > > > this 'hot' device (which impacts your temp sensor reported value). > > > > > > I think the two boards you point at (homestar and coachz) are just the > > > two that override the default defined in the SoC dtsi file. If you > > > look in sc7180.dtsi you'll see 'gpuss1-thermal' which has a cooling > > > map. You can also see the cooling maps for the littles. > > > > Yep, plus thermal zones with cooling maps for the big cores. > > > > > I guess we don't have a `dynamic-power-coefficient` for the GPU, > > > though? Seems like we should, but I haven't dug through all the code > > > here... > > > > To my knowledge the SC7x80 GPU doesn't register an energy model, which is > > one of the reasons the GPU wasn't included as cooling device for > > 'skin_temp_thermal'. > > > > You can give it a try by editing the DT and adding in the > GPU node the 'dynamic-power-coefficient' + probably > small modification in the driver code. > > If the GPU driver registers the cooling device in the new way, you > would also get EM registered thanks to the devfreq cooling new code > (commit: 84e0d87c9944eb36ae6037a). > > You can check an example from Panfrost GPU driver [1]. Ah, I missed that, thanks for the pointer! > I can see some upstream MSM GPU driver, but I don't know if that is > your GPU driver. It registers the 'old' way the devfreq cooling [2] > but it would be easy to change to use the new function. > The GPU driver would use the same dev_pm_opp_of_register_em() as > your CPUs do, so EM would be in 'milli-Watts' (so should be fine). Yep, that's whay we are using.