From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rajat Jain <rajatja@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-pci@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rajat Jain <rajatxjain@gmail.com>,
Dmitry Torokhov <dtor@google.com>,
Jesse Barnes <jsbarnes@google.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Pavel Machek <pavel@denx.de>,
Oliver O'Halloran <oohall@gmail.com>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH v3] PCI: ACPI: Support Microsoft's "DmaProperty"
Date: Thu, 17 Feb 2022 07:16:22 +0100 [thread overview]
Message-ID: <Yg3oNkwS3XSzmJAu@kroah.com> (raw)
In-Reply-To: <20220216220541.1635665-1-rajatja@google.com>
On Wed, Feb 16, 2022 at 02:05:41PM -0800, Rajat Jain wrote:
> The "DmaProperty" is supported and documented by Microsoft here:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports
> They use this property for DMA protection:
> https://docs.microsoft.com/en-us/windows/security/information-protection/kernel-dma-protection-for-thunderbolt
>
> Support the "DmaProperty" with the same semantics. Windows documents the
> property to apply to PCIe root ports only. Extend it to apply to any
> PCI device. This is useful for internal PCI devices that do not hang off
> a PCIe rootport, but offer an attack surface for DMA attacks (e.g.
> internal network devices).
>
> Signed-off-by: Rajat Jain <rajatja@google.com>
> ---
> v3: * Use Microsoft's documented property "DmaProperty"
> * Resctrict to ACPI only
>
> drivers/pci/pci-acpi.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index a42dbf448860..660baa60c040 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -1350,12 +1350,30 @@ static void pci_acpi_set_external_facing(struct pci_dev *dev)
> dev->external_facing = 1;
> }
>
> +static void pci_acpi_check_for_dma_protection(struct pci_dev *dev)
> +{
> + u8 val;
> +
> + /*
> + * Microsoft Windows uses this property, and is documented here:
> + * https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports
> + * While Microsoft documents this property as only applicable to PCIe
> + * root ports, we expand it to be applicable to any PCI device.
> + */
> + if (device_property_read_u8(&dev->dev, "DmaProperty", &val))
> + return;
Why not continue to only do this for PCIe devices like it is actually
being used for? Why expand it?
And what driver/device is going to use this?
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-17 6:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 22:05 [PATCH v3] PCI: ACPI: Support Microsoft's "DmaProperty" Rajat Jain
2022-02-17 6:16 ` Greg Kroah-Hartman [this message]
2022-02-17 18:26 ` Rajat Jain
2022-02-17 18:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg3oNkwS3XSzmJAu@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=dtor@google.com \
--cc=helgaas@kernel.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=jsbarnes@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=oohall@gmail.com \
--cc=pavel@denx.de \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).