From: Greg KH <gregkh@linuxfoundation.org>
To: "Starke, Daniel" <daniel.starke@siemens.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] tty: n_gsm: fix encoding of control signal octet bit DV
Date: Thu, 17 Feb 2022 15:50:32 +0100 [thread overview]
Message-ID: <Yg5guD36Usz3cV83@kroah.com> (raw)
In-Reply-To: <AM4PR1001MB137883EF5392EE25ED70A912E0369@AM4PR1001MB1378.EURPRD10.PROD.OUTLOOK.COM>
On Thu, Feb 17, 2022 at 02:03:37PM +0000, Starke, Daniel wrote:
> > > > All of these are patch 1/1, which is odd :(
> > > >
> > > > Please renumber them properly and resend.
> > >
> > > All these patches are based on the current version of tty-next and are
> > > completely independent from each other. The only common part is the
> > > file they apply to. Therefore, this is not a patch series. Would you
> > > still suggest to apply a different numbering?
> >
> > Yes, please send them as a patch series, numbered correctly, as a whole
> > series of patches, all listed as 1/1 does not do good things for our
> > tools.
>
> I have noticed that all patches have been sent in one thread. This was not
> my intention. I see two options here now:
> 1. Resend all patches one by one as they are completely independent.
> 2. Create a patch series.
>
> And the following two variants in case of option 2:
> a. Just renumber the subjects and resend all (i.e. without a cover letter).
This is fine, and the easiest for everyone involved, as git makes it
automatic.
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-17 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:03 [PATCH 1/1] tty: n_gsm: fix encoding of control signal octet bit DV Starke, Daniel
2022-02-17 14:50 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-17 10:45 Starke, Daniel
2022-02-17 12:27 ` Greg KH
2022-02-17 8:05 daniel.starke
2022-02-17 9:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg5guD36Usz3cV83@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.starke@siemens.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).