From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Fabien Parent <fparent@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] Input: mtk-pmic-keys - use get_irq_byname() instead of index
Date: Mon, 7 Feb 2022 21:51:37 -0800 [thread overview]
Message-ID: <YgIE6ZVNFPS1ffUR@google.com> (raw)
In-Reply-To: <20220121140323.4080640-2-mkorpershoek@baylibre.com>
On Fri, Jan 21, 2022 at 03:03:20PM +0100, Mattijs Korpershoek wrote:
> Some pmics of the mt6397 family (such as MT6358), have two IRQs per
> physical key: one for press event, another for release event.
>
> The mtk-pmic-keys driver assumes that each key only has one
> IRQ. The key index and the RES_IRQ resource index have a 1/1 mapping.
>
> This won't work for MT6358, as we have multiple resources (2) for one key.
>
> To prepare mtk-pmic-keys to support MT6358, retrieve IRQs by name
> instead of by index.
>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2022-02-08 5:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:03 [PATCH v4 0/4] input: MT6358 PMIC button support Mattijs Korpershoek
2022-01-21 14:03 ` [PATCH v4 1/4] Input: mtk-pmic-keys - use get_irq_byname() instead of index Mattijs Korpershoek
2022-02-08 5:51 ` Dmitry Torokhov [this message]
2022-01-21 14:03 ` [PATCH v4 2/4] dt-bindings: input: mtk-pmic-keys: add MT6358 binding definition Mattijs Korpershoek
2022-02-08 5:51 ` Dmitry Torokhov
2022-01-21 14:03 ` [PATCH v4 3/4] Input: mtk-pmic-keys - add support for MT6358 Mattijs Korpershoek
2022-02-08 5:51 ` Dmitry Torokhov
2022-01-21 14:03 ` [PATCH v4 4/4] arm64: dts: mt6358: add mt6358-keys node Mattijs Korpershoek
2022-02-08 15:38 ` Mattijs Korpershoek
2022-03-01 7:44 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgIE6ZVNFPS1ffUR@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).