From: Rob Herring <robh@kernel.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] dt-bindings: rtc: pcf2127: add PCF2131 INT_A and INT_B support
Date: Tue, 8 Feb 2022 21:20:28 -0600 [thread overview]
Message-ID: <YgMy/CYL8lmf6Y+J@robh.at.kernel.org> (raw)
In-Reply-To: <20220125200009.900660-11-hugo@hugovil.com>
On Tue, Jan 25, 2022 at 03:00:09PM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> The PCF2131 has two output interrupt pins, named INT_A and INT_B.
>
> Add properties to identify onto which pin we want the alarm interrupt
> to be routed. It can be either one, or both.
>
> These properties are automatically set to false for variants other
> than PCF2131 (ex: PCF2127).
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> .../devicetree/bindings/rtc/nxp,pcf2127.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> index 57eb0a58afa3..83656dd2f97f 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -24,6 +24,16 @@ properties:
> interrupts:
> maxItems: 1
>
> + alarm-output-a:
nxp,alarm-output-a
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Enable alarm interrupt on INT_A output pin.
> +
> + alarm-output-b:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Enable alarm interrupt on INT_B output pin.
> +
> start-year: true
>
> reset-source: true
> @@ -32,6 +42,18 @@ required:
> - compatible
> - reg
>
> +if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - nxp,pcf2131
> +then:
> + properties:
> + alarm-output-a: false
> + alarm-output-b: false
> +
> additionalProperties: false
>
> examples:
> @@ -62,6 +84,7 @@ examples:
> pinctrl-0 = <&rtc_nint_pins>;
> interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> reset-source;
> + alarm-output-b;
> };
> };
>
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2022-02-09 4:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220125200009.900660-1-hugo@hugovil.com>
2022-01-25 20:00 ` [PATCH 01/10] rtc: pcf2127: add variant-specific configuration structure Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 02/10] rtc: pcf2127: adapt for time/date registers at any offset Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 03/10] rtc: pcf2127: adapt for alarm " Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 04/10] rtc: pcf2127: adapt for WD " Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 05/10] rtc: pcf2127: adapt for CLKOUT register " Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 06/10] rtc: pcf2127: add support for multiple TS functions Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 07/10] rtc: pcf2127: add support for PCF2131 RTC Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 08/10] rtc: pcf2127: add support for PCF2131 alarm interrupt on outputs INT_A/B Hugo Villeneuve
2022-01-25 20:00 ` [PATCH 09/10] dt-bindings: rtc: pcf2127: add PCF2131 Hugo Villeneuve
2022-02-09 3:23 ` Rob Herring
2022-01-25 20:00 ` [PATCH 10/10] dt-bindings: rtc: pcf2127: add PCF2131 INT_A and INT_B support Hugo Villeneuve
2022-02-09 3:20 ` Rob Herring [this message]
2022-02-10 22:12 ` Hugo Villeneuve
2022-02-10 22:32 ` Alexandre Belloni
2022-02-10 22:55 ` Hugo Villeneuve
2022-02-11 20:16 ` Hugo Villeneuve
2022-02-11 21:02 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgMy/CYL8lmf6Y+J@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).