From: Christoph Hellwig <hch@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH REPOST] irq_poll: Add local_bh_disable() in cpu_dead notifier
Date: Tue, 8 Feb 2022 23:56:34 -0800 [thread overview]
Message-ID: <YgNzsnIE9bwQZ1Zg@infradead.org> (raw)
In-Reply-To: <YgJ/XWVxxWDVBBVA@linutronix.de>
On Tue, Feb 08, 2022 at 03:34:05PM +0100, Sebastian Andrzej Siewior wrote:
> __raise_softirq_irqoff() adds a bit to the pending sofirq mask and this
> is it. The softirq won't be handled in a deterministic way but randomly
> when an interrupt fires and handles the softirq in its irq_exit() routine or
> if something randomly checks and handles pending softirqs in the call
> chain before the CPU goes idle.
>
> Add a local_bh_disable/enable() around the IRQ-off section which will
> handle pending softirqs.
And I still haven't seen any good explanation of why this is useful.
next prev parent reply other threads:[~2022-02-09 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 14:34 [PATCH REPOST] irq_poll: Add local_bh_disable() in cpu_dead notifier Sebastian Andrzej Siewior
2022-02-09 7:56 ` Christoph Hellwig [this message]
2022-02-10 12:33 ` Sebastian Andrzej Siewior
2022-02-11 6:34 ` Christoph Hellwig
2022-02-11 15:09 ` Sebastian Andrzej Siewior
2022-04-10 12:44 ` Thomas Gleixner
2022-04-10 12:49 ` [PATCH V2] lib/irq_poll: Add local_bh_disable() in irq_poll_cpu_dead() Thomas Gleixner
2022-04-13 19:38 ` [tip: core/core] lib/irq_poll: Prevent softirq pending leak " tip-bot2 for Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgNzsnIE9bwQZ1Zg@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).