From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F23A4C433FE for ; Fri, 11 Feb 2022 12:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350336AbiBKM65 (ORCPT ); Fri, 11 Feb 2022 07:58:57 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239825AbiBKM64 (ORCPT ); Fri, 11 Feb 2022 07:58:56 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9C34DC7 for ; Fri, 11 Feb 2022 04:58:55 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 88CA221138; Fri, 11 Feb 2022 12:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1644584334; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tBJzK3Xs58/dlpJBfGVQOczArNiv86+UHyJMSbBZyMM=; b=QUCYi7YabQyrGnLS1xAh+c0yPGGr1mNCY3Ifdqs9DohNrGH0s2/1g6dyylorGOlfGTdmmA HzsJNN0YU/DVCl9BL1J/aQSp2sPxRx/n2vrnjm15VMCJQDT0QWrWhLTeOgFrgDEuADFjJm J561b4rmtrIUTVFGWRVDGmb8AoxvdQg= Received: from suse.cz (unknown [10.100.224.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 69B78A3B83; Fri, 11 Feb 2022 12:58:54 +0000 (UTC) Date: Fri, 11 Feb 2022 13:58:54 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v1 02/13] printk: cpu sync always disable interrupts Message-ID: References: <20220207194323.273637-1-john.ogness@linutronix.de> <20220207194323.273637-3-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207194323.273637-3-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2022-02-07 20:49:12, John Ogness wrote: > The CPU sync functions are a NOP for !CONFIG_SMP. But for > !CONFIG_SMP they still need to disable interrupts in order to > preserve context within the CPU sync sections. > > Signed-off-by: John Ogness Good catch! It is interesting that the original code did not disable interrupts around __dump_stack() on non-SMP, see the commit 766c268bc6d39b8124 ("lib/dump_stack: move cpu lock to printk.c"). But it was rather a bug. The patch makes perfect sense. Reviewed-by: Petr Mladek Best Regards, Petr