From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E488C43217 for ; Sun, 13 Feb 2022 06:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234051AbiBMG53 (ORCPT ); Sun, 13 Feb 2022 01:57:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234043AbiBMG5K (ORCPT ); Sun, 13 Feb 2022 01:57:10 -0500 Received: from isilmar-4.linta.de (isilmar-4.linta.de [136.243.71.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 861B45DE65 for ; Sat, 12 Feb 2022 22:57:05 -0800 (PST) X-isilmar-external: YES X-isilmar-external: YES X-isilmar-external: YES Received: from owl.dominikbrodowski.net (owl.brodo.linta [10.2.0.111]) by isilmar-4.linta.de (Postfix) with ESMTPSA id 246FC201417; Sun, 13 Feb 2022 06:57:00 +0000 (UTC) Received: by owl.dominikbrodowski.net (Postfix, from userid 1000) id 707DF80871; Sun, 13 Feb 2022 07:54:07 +0100 (CET) Date: Sun, 13 Feb 2022 07:54:07 +0100 From: Dominik Brodowski To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, Theodore Ts'o Subject: Re: [PATCH v2 04/10] random: group initialization wait functions Message-ID: References: <20220212122318.623435-1-Jason@zx2c4.com> <20220212122318.623435-5-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220212122318.623435-5-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +/* > + * Returns whether or not the urandom pool has been seeded and thus guaranteed > + * to supply cryptographically secure random numbers. This applies to: the > + * /dev/urandom device, the get_random_bytes function, and the get_random_{u32, > + * ,u64,int,long} family of functions. > + * > + * Returns: true if the urandom pool has been seeded. > + * false if the urandom pool has not been seeded. I think this comment should be updated, as there is no "urandom pool"; instead we should refer to the "random pool" or the "random base pool". > +/* > + * Wait for the urandom pool to be seeded and thus guaranteed to supply > + * cryptographically secure random numbers. This applies to: the /dev/urandom > + * device, the get_random_bytes function, and the get_random_{u32,u64,int,long} > + * family of functions. Using any of these functions without first calling > + * this function forfeits the guarantee of security. > + * > + * Returns: 0 if the urandom pool has been seeded. > + * -ERESTARTSYS if the function was interrupted by a signal. Same here. > +/* > + * Add a callback function that will be invoked when the nonblocking > + * pool is initialised. Same here ("nonblocking pool"). Other than that, looks fine. Thanks, Dominik