From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD7FC433F5 for ; Mon, 14 Feb 2022 13:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353929AbiBNNJV (ORCPT ); Mon, 14 Feb 2022 08:09:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233705AbiBNNJT (ORCPT ); Mon, 14 Feb 2022 08:09:19 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AAD54B85D; Mon, 14 Feb 2022 05:09:11 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 870A01EC00F8; Mon, 14 Feb 2022 14:09:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1644844145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Bfa8NKJ66AaG5XA2+aWkSTSm4HHtiIWE39IjIhrlAVk=; b=faT7mfWHnTdzSgditcakDZLhYSRjoh05y52NKwdmwEVm7whVeT+q6RthAaWRG1Ft+Jj/vr i8mvLGORI4j0SpGaj1bCQXzUPk2la74+U0xcmzLC+C8AQsAoKaQeLgGA6Y81ShPf08Ucug m6fVT6ecoyOCTV8zINM8FeHybRk9XFg= Date: Mon, 14 Feb 2022 14:09:07 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH v4 18/24] EDAC/amd64: Define function to insert CS ID into address Message-ID: References: <20220127204115.384161-1-yazen.ghannam@amd.com> <20220127204115.384161-19-yazen.ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220127204115.384161-19-yazen.ghannam@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 08:41:09PM +0000, Yazen Ghannam wrote: > @@ -1326,20 +1331,7 @@ static int denormalize_addr(struct addr_ctx *ctx) > return -EINVAL; > } > > - if (num_intlv_bits > 0) { > - u64 temp_addr_i; > - > - /* > - * The pre-interleaved address consists of XXXXXXIIIYYYYY > - * where III is the ID for this CS, and XXXXXXYYYYY are the > - * address bits from the post-interleaved address. > - * "num_intlv_bits" has been calculated to tell us how many "I" > - * bits there are. "intlv_addr_bit" tells us how many "Y" bits > - * there are (where "I" starts). > - */ That comment looks useful, why remove it? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette