From: Vinod Koul <vkoul@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
ludovic.desroches@microchip.com, tudor.ambarus@microchip.com
Subject: Re: [PATCH -next] dmaengine: at_xdmac: Fix missing unlock in at_xdmac_tasklet()
Date: Tue, 15 Feb 2022 10:56:15 +0530 [thread overview]
Message-ID: <Ygs5d3MFR7R+Z5YA@matsya> (raw)
In-Reply-To: <20220107024047.1051915-1-yangyingliang@huawei.com>
On 07-01-22, 10:40, Yang Yingliang wrote:
> Add the missing unlock before return from at_xdmac_tasklet().
Applied, thanks
>
> Fixes: e77e561925df ("dmaengine: at_xdmac: Fix race over irq_status")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/dma/at_xdmac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index a1da2b4b6d73..1476156af74b 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1681,8 +1681,10 @@ static void at_xdmac_tasklet(struct tasklet_struct *t)
> __func__, atchan->irq_status);
>
> if (!(atchan->irq_status & AT_XDMAC_CIS_LIS) &&
> - !(atchan->irq_status & error_mask))
> + !(atchan->irq_status & error_mask)) {
> + spin_unlock_irq(&atchan->lock);
> return;
> + }
>
> if (atchan->irq_status & error_mask)
> at_xdmac_handle_error(atchan);
> --
> 2.25.1
--
~Vinod
prev parent reply other threads:[~2022-02-15 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 2:40 [PATCH -next] dmaengine: at_xdmac: Fix missing unlock in at_xdmac_tasklet() Yang Yingliang
2022-01-07 7:26 ` Tudor.Ambarus
2022-02-15 5:26 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygs5d3MFR7R+Z5YA@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=tudor.ambarus@microchip.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).