From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
miaoqing@codeaurora.org, rsalvaterra@gmail.com,
"Jason Cooper" <jason@lakedaemon.net>,
"Sepehrdad, Pouyan" <pouyans@qti.qualcomm.com>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Kalle Valo" <kvalo@kernel.org>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
LKML <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] ath9k: use hw_random API instead of directly dumping into random.c
Date: Wed, 16 Feb 2022 08:11:05 +0100 [thread overview]
Message-ID: <Ygyjib2FKY87S7/H@owl.dominikbrodowski.net> (raw)
In-Reply-To: <CAHmME9pZaYW-p=zU4v96TjeSijm-g03cNpvUJcNvhOqh5v+Lwg@mail.gmail.com>
Am Wed, Feb 16, 2022 at 12:52:15AM +0100 schrieb Jason A. Donenfeld:
> On 2/16/22, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> >> @@ -22,9 +22,6 @@
> >> #include "hw.h"
> >> #include "ar9003_phy.h"
> >>
> >> -#define ATH9K_RNG_BUF_SIZE 320
> >> -#define ATH9K_RNG_ENTROPY(x) (((x) * 8 * 10) >> 5) /* quality: 10/32 */
> >
> > So this comment says "quality: 10/32" but below you're setting "quality"
> > as 320. No idea what the units are supposed to be, but is this right?
>
> I think the unit is supposed to be how many entropic bits there are
> out of 1024 bits? These types of estimates are always BS, so keeping
> it on the lower end as before seemed right. Herbert can jump in here
> if he has a better idea; that's his jig.
10/32 = 320/1024, so that change is correct.
Dominik
prev parent reply other threads:[~2022-02-16 7:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHmME9rkTP7bJBDvnejQ6BGPu13qpHKbtnjt3h33NEaTnYLirg@mail.gmail.com>
2022-02-15 15:38 ` ath9k should perhaps use hw_random api? Jason A. Donenfeld
2022-02-15 16:28 ` [PATCH] ath9k: use hw_random API instead of directly dumping into random.c Jason A. Donenfeld
2022-02-15 22:55 ` Rui Salvaterra
2022-02-15 23:22 ` Toke Høiland-Jørgensen
2022-02-15 23:52 ` Jason A. Donenfeld
2022-02-16 0:02 ` [PATCH v2] " Jason A. Donenfeld
2022-02-16 3:13 ` Florian Fainelli
2022-02-16 10:43 ` Jason A. Donenfeld
2022-02-16 11:33 ` [PATCH v3] " Jason A. Donenfeld
2022-02-16 13:27 ` Rui Salvaterra
2022-02-17 13:51 ` Toke Høiland-Jørgensen
2022-02-21 10:22 ` Kalle Valo
2022-02-22 10:01 ` Ard Biesheuvel
2022-02-22 10:13 ` Jason A. Donenfeld
2022-02-16 5:38 ` [PATCH v2] " Kalle Valo
2022-02-16 7:15 ` Dominik Brodowski
2022-02-16 7:11 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygyjib2FKY87S7/H@owl.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=Jason@zx2c4.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=kvalo@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=pouyans@qti.qualcomm.com \
--cc=rsalvaterra@gmail.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).