From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D78DFC433F5 for ; Tue, 1 Mar 2022 08:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232467AbiCAIOh (ORCPT ); Tue, 1 Mar 2022 03:14:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiCAIOf (ORCPT ); Tue, 1 Mar 2022 03:14:35 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDA2345785; Tue, 1 Mar 2022 00:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZKFMzW+Kv859HQuOCSrtHRjHr81yrDge18ehzpKSGjE=; b=Wc1YJkdbx0+7ppx32Pf7erlmtn 84YNscLIGC1EB1Aj+TAWGXCyTQh3AtwRW8Ccr3lALMMmjEwZ4+5Ommu6/VVnOhDUoqNMmy4NzhNvG oCaWkGg8nz+rpkWbXZvof1bcNrDpSJGcD8ASv+qgYH2wAMXvNWTSXD0Pr2V79k9k3bxznmrjHK5XZ REiKcBAw1B5kAlLs5CheLYJUcabGItx20jaPlMW7X0g+BD0Qjzh+uKeiyJpBMEXGym4A1QeyUd8vV ADUui96TURRvs42n7iSCddMlzzV5Ml+7ZrQ1iCqkEWItpesEzeAmUYKe+LwJBkV94pGedqAvMPlCy Hcq4fT3Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOxdf-00FXIk-7i; Tue, 01 Mar 2022 08:13:43 +0000 Date: Tue, 1 Mar 2022 00:13:43 -0800 From: Christoph Hellwig To: "David E. Box" Cc: nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev, lorenzo.pieralisi@arm.com, hch@infradead.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, michael.a.bottini@linux.intel.com, rafael@kernel.org, me@adhityamohan.in, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V6 1/3] PCI/ASPM: Add pci_enable_default_link_state() Message-ID: References: <20220301041943.2935892-1-david.e.box@linux.intel.com> <20220301041943.2935892-2-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220301041943.2935892-2-david.e.box@linux.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 08:19:41PM -0800, David E. Box wrote: > + down_read(&pci_bus_sem); > + mutex_lock(&aspm_lock); > + link->aspm_default = 0; > + if (state & PCIE_LINK_STATE_L0S) > + link->aspm_default |= ASPM_STATE_L0S; > + if (state & PCIE_LINK_STATE_L1) > + /* L1 PM substates require L1 */ > + link->aspm_default |= ASPM_STATE_L1 | ASPM_STATE_L1SS; > + if (state & PCIE_LINK_STATE_L1_1) > + link->aspm_default |= ASPM_STATE_L1_1; > + if (state & PCIE_LINK_STATE_L1_2) > + link->aspm_default |= ASPM_STATE_L1_2; > + if (state & PCIE_LINK_STATE_L1_1_PCIPM) > + link->aspm_default |= ASPM_STATE_L1_1_PCIPM; > + if (state & PCIE_LINK_STATE_L1_2_PCIPM) > + link->aspm_default |= ASPM_STATE_L1_2_PCIPM; > + pcie_config_aspm_link(link, policy_to_aspm_state(link)); Is there any reason the ASPM_* values aren't passed directly to this function?