From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE8CEC433EF for ; Tue, 1 Mar 2022 16:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236207AbiCAQb7 (ORCPT ); Tue, 1 Mar 2022 11:31:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234132AbiCAQb4 (ORCPT ); Tue, 1 Mar 2022 11:31:56 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 713115C34F for ; Tue, 1 Mar 2022 08:31:15 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id 15-20020a17090a098f00b001bef0376d5cso193795pjo.5 for ; Tue, 01 Mar 2022 08:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6jVdVhZ/PX1RQ+F2J/N7Wi0Epu+QUrcTFuFOjJu3yvg=; b=EiyC3jiQYZWgQziJlTfFIb9km0pyKksaEl018V+KwL+9NwfefWny7QIjtTju1hcH8E zFFC5tdrAieXovAiXyYHe5OloYzfsUeLYK/ZWFZ4IgOShHk+G0nRzG/G7+XBU4oj/LM6 m864fHcNwh3qt303r6oTcwO0x2KWNruxeCWQfmyElTro4rroTBoUd9FyfVmyLZXsePQB Dl55BFoPqpsUbyyDo6B3U2m66AVEabkaRCCKM7c8wcqRCTuWiDzV8i3dZTuTa3FKtSqg EZi2+FsqpCP9v0c8LK0bZES6dEiKbTKMbIhA2XywlKzAnYMhYi1H9QJ+lUG/+Z8PmJb7 H3GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6jVdVhZ/PX1RQ+F2J/N7Wi0Epu+QUrcTFuFOjJu3yvg=; b=Pr/x6pJBwT/Tz80Gn/WIHf728Zz0VkCNv1d97/JpEISWQ26xhmufSY3lglls9pyrly Wh1SPaqKhnkmCDU4Ye6nb8znq4gG+XQOe6LPjly1Yi2eErFGDIKmG2Kh21/NlRuof7ZG nzkPVXF+ykrDAJ+g6aBbdd6BXWRoBOFrVG7cHm4YwC+loC4GTQmRAL66Vs81J719rLt1 yyk/oSQmOAqm2dWZVCFbyjl3/PBCrywz182rPKZwUN1ryz3w2frA0uEnlDb3FSs3FhqQ Rji0boEw0iy+qB00/djt/dXOjzoOMvI6tO5rEA7+QR0JDMWtMpqQVfM2+TShWsrsK76N 5zYQ== X-Gm-Message-State: AOAM532rbb7K2hcnDH7/96gaWAmJwtZvRL31wy6kRRcZGCNlrWdONFdd 0Ikgw85Q0jFymSIYdtrrR7vjpg== X-Google-Smtp-Source: ABdhPJwRhnOCWVs+nTyAnV4Bkol2CdMiJ1PzAB3dyOjKWluh1b+oelAli3twkYxK5O5lIJguP3uCNw== X-Received: by 2002:a17:903:310d:b0:151:6d4b:a274 with SMTP id w13-20020a170903310d00b001516d4ba274mr9655599plc.130.1646152274727; Tue, 01 Mar 2022 08:31:14 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id c7-20020a056a00248700b004e1dc9aeb81sm18836302pfv.71.2022.03.01.08.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 08:31:14 -0800 (PST) Date: Tue, 1 Mar 2022 16:31:10 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Jim Mattson , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Vitaly Kuznetsov , Paolo Bonzini , Joerg Roedel , Thomas Gleixner , Dave Hansen , Wanpeng Li , Borislav Petkov , x86@kernel.org Subject: Re: [PATCH 1/4] KVM: x86: mark synthetic SMM vmexit as SVM_EXIT_SW Message-ID: References: <20220301135526.136554-1-mlevitsk@redhat.com> <20220301135526.136554-2-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220301135526.136554-2-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2022, Maxim Levitsky wrote: > Use a dummy unused vmexit reason to mark the 'VM exit' that is happening > when kvm exits to handle SMM, which is not a real VM exit. Why not use "62h VMEXIT_SMI"? > This makes it a bit easier to read the KVM trace, and avoids > other potential problems. What other potential problems? > Signed-off-by: Maxim Levitsky > --- > arch/x86/kvm/svm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 7038c76fa8410..c08fd7f4f3414 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -4218,7 +4218,7 @@ static int svm_enter_smm(struct kvm_vcpu *vcpu, char *smstate) > svm->vmcb->save.rsp = vcpu->arch.regs[VCPU_REGS_RSP]; > svm->vmcb->save.rip = vcpu->arch.regs[VCPU_REGS_RIP]; > > - ret = nested_svm_vmexit(svm); > + ret = nested_svm_simple_vmexit(svm, SVM_EXIT_SW); > if (ret) > return ret; > > -- > 2.26.3 >