From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B3BC433EF for ; Mon, 21 Feb 2022 05:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231744AbiBUFBM (ORCPT ); Mon, 21 Feb 2022 00:01:12 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230052AbiBUFBM (ORCPT ); Mon, 21 Feb 2022 00:01:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97301443E1 for ; Sun, 20 Feb 2022 21:00:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27F3B611C1 for ; Mon, 21 Feb 2022 05:00:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66AB2C340E9; Mon, 21 Feb 2022 05:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645419648; bh=/qAyC0tU1D8M/i6ApYcHygtrtCpo+lWb1lQXeoSP/zk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=McSO/3xGqzaewex3EegJpxO0UPYD/nZVnMj1EITQLRnLkpkmr0l1sCPfB8QM+vNMc wgOQJwQ8SStyBhtYlvCDNUDM3l67Eu05GAXjm5M4lq3adUznXEpvh/LGVuVAjJlHIk p/6Lg6vXYUrfJlp/NbkRGqRy1I7PUJVgeZsksif4X5NsALmlTBeGfLC7ZvGpYtuc9K 4fyCY4M72P2ARNSD6tq7J6djP0cnlKTKZRkM9Q4FrmJs/6smryr7+iF3y+ljs5o+LU /1mRFwnvR5ipL2v+28vwFUSWi09u0csy//FoxvaXPdBolPIapVUlv2F/QV6VJUixUx dzvm1yd85zQaA== Date: Sun, 20 Feb 2022 21:00:47 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, linux@dominikbrodowski.net, Theodore Ts'o Subject: Re: [PATCH v2 05/10] random: group crng functions Message-ID: References: <20220212122318.623435-1-Jason@zx2c4.com> <20220212122318.623435-6-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220212122318.623435-6-Jason@zx2c4.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 12, 2022 at 01:23:13PM +0100, Jason A. Donenfeld wrote: > - /* We copy the new key into the base_crng, overwriting the old one, > + /* > + * We copy the new key into the base_crng, overwriting the old one, > * and update the generation counter. We avoid hitting ULONG_MAX, > * because the per-cpu crngs are initialized to ULONG_MAX, so this > * forces new CPUs that come online to always initialize. > @@ -635,13 +472,11 @@ static void crng_reseed(void) Overall looks good, but it's not ideal seeing comments reformatted like this rather than doing them the right way from the beginning. Reviewed-by: Eric Biggers - Eric