linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Woody Suwalski <wsuwalski@gmail.com>,
	Florian Westphal <fw@strlen.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Netdev <netdev@vger.kernel.org>
Subject: Re: Linux 5.17-rc5
Date: Mon, 21 Feb 2022 19:42:09 +0100	[thread overview]
Message-ID: <YhPdAeNwgffXqvfO@salvia> (raw)
In-Reply-To: <CANn89i+72dv1AaeE1ThkceMVBHGCh3P49hOwuCkMSb1Y6U=hmg@mail.gmail.com>

On Mon, Feb 21, 2022 at 10:28:46AM -0800, Eric Dumazet wrote:
> On Mon, Feb 21, 2022 at 10:25 AM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> >
> > On Mon, Feb 21, 2022 at 10:21:16AM -0800, Eric Dumazet wrote:
> > > On Mon, Feb 21, 2022 at 10:08 AM Linus Torvalds
> > > <torvalds@linux-foundation.org> wrote:
> > > >
> > > > On Mon, Feb 21, 2022 at 10:02 AM Eric Dumazet <edumazet@google.com> wrote:
> > > > >
> > > > > I am pretty sure Pablo fixed this one week ago.
> > > >
> > > > .. looks about right. Apart from the "it was never sent to me, so -rc5
> > > > ended up showing the problem" part.
> > > >
> > >
> > > Indeed, I personally these kinds of trivial fixes should be sent right away,
> > > especially considering two bots complained about it.
> >
> > I did not consider this so important, that was my fault.
> 
> Well, I was the one adding this compile error ;)

I poorly performed as a duly reviewer :)

> Testing CONFIG_IPV6=n builds is not my top priority.

For the record, this patch is now flying to the netdev tree via pull request:

https://patchwork.kernel.org/project/netdevbpf/patch/20220221161757.250801-1-pablo@netfilter.org/

Thanks.

  reply	other threads:[~2022-02-21 18:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20 21:19 Linux 5.17-rc5 Linus Torvalds
2022-02-20 23:37 ` Robert Gadsdon
2022-02-21 16:11   ` Woody Suwalski
2022-02-21 14:23 ` Woody Suwalski
2022-02-21 17:56   ` Linus Torvalds
2022-02-21 18:01     ` Eric Dumazet
2022-02-21 18:07       ` Linus Torvalds
2022-02-21 18:21         ` Eric Dumazet
2022-02-21 18:25           ` Pablo Neira Ayuso
2022-02-21 18:28             ` Eric Dumazet
2022-02-21 18:42               ` Pablo Neira Ayuso [this message]
2022-02-21 18:22         ` Woody Suwalski
2022-02-21 18:25         ` Pablo Neira Ayuso
2022-02-21 19:52       ` Robert Gadsdon
2022-02-21 17:44 Linus Torvalds
2022-02-21 18:10 ` Guenter Roeck
2022-02-21 18:31   ` Linus Torvalds
2022-02-21 20:44     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhPdAeNwgffXqvfO@salvia \
    --to=pablo@netfilter.org \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=wsuwalski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).