From: Michal Hocko <mhocko@suse.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Zhenguo Yao <yaozhenguo1@gmail.com>,
Liu Yuntao <liuyuntao10@huawei.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] hugetlb: clean up potential spectre issue warnings
Date: Tue, 22 Feb 2022 08:47:36 +0100 [thread overview]
Message-ID: <YhSVGPQ6VIQfBZ9o@dhcp22.suse.cz> (raw)
In-Reply-To: <26565cd7-01b0-197c-6ce9-af92f5bc8563@oracle.com>
On Mon 21-02-22 12:24:25, Mike Kravetz wrote:
> On 2/21/22 00:42, Michal Hocko wrote:
> > On Fri 18-02-22 13:29:46, Mike Kravetz wrote:
> > [...]
> >> @@ -4161,7 +4162,7 @@ static int __init hugepages_setup(char *s)
> >> }
> >> if (tmp >= nr_online_nodes)
> >> goto invalid;
> >> - node = tmp;
> >> + node = array_index_nospec(tmp, nr_online_nodes);
> >> p += count + 1;
> >> /* Parse hugepages */
> >> if (sscanf(p, "%lu%n", &tmp, &count) != 1)
> >> @@ -6889,9 +6890,9 @@ static int __init cmdline_parse_hugetlb_cma(char *p)
> >> break;
> >>
> >> if (s[count] == ':') {
> >> - nid = tmp;
> >> - if (nid < 0 || nid >= MAX_NUMNODES)
> >> + if (tmp >= MAX_NUMNODES)
> >> break;
> >> + nid = array_index_nospec(tmp, MAX_NUMNODES);
> >>
> >> s += count + 1;
> >> tmp = memparse(s, &s);
> >
> > This is an early boot code, how is this supposed to be used as a side
> > channel?
>
> I do not have an evil hacker mind, but I can not think of a way this one time
> use of a user specified index could be an issue. It does add noise to the
> BUILD REGRESSION emails sent to Andrew.
Maybe Smack can be taught to ignore __init and other early boot
functions.
I do not have any strong objections to using array_index_nospec because
it won't do any harm. Except that it makes a security measure a normal
comodity so any future changes to array_index_nospec and its users will
have to consult additional callers. Whether that is something we should
deeply care about, I don't know.
At minimum make sure to be explicit that this can hardly be a Spectre
gadget as it is a _one_ time early boot call. If there is a scenario
where this could be really abused then it should be mentioned
explicitly.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2022-02-22 7:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 21:29 [PATCH v2] hugetlb: clean up potential spectre issue warnings Mike Kravetz
2022-02-21 8:42 ` Michal Hocko
2022-02-21 20:24 ` Mike Kravetz
2022-02-22 7:47 ` Michal Hocko [this message]
2022-02-22 16:15 ` Schaufler, Casey
2022-02-22 16:36 ` Dan Carpenter
2022-02-23 8:35 ` Michal Hocko
2022-02-22 21:53 ` Mike Kravetz
2022-02-23 8:33 ` Michal Hocko
2022-02-23 18:36 ` Mike Kravetz
2022-02-24 9:31 ` Michal Hocko
2022-02-24 4:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhSVGPQ6VIQfBZ9o@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuyuntao10@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=yaozhenguo1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).