From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Brian Geffon <bgeffon@google.com>,
Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: dm: introduce a DM_ENFORCE_OPEN_COUNT flag.
Date: Tue, 22 Feb 2022 14:16:13 -0500 [thread overview]
Message-ID: <YhU2faRZJ4NstJ6L@redhat.com> (raw)
In-Reply-To: <YfqYTuhGqOl4SneK@infradead.org>
On Wed, Feb 02 2022 at 9:42P -0500,
Christoph Hellwig <hch@infradead.org> wrote:
> Withmy block hat on: nak to this. No block driver has any business at
> all rejecting "too many openers". In fact any opener but the first of
> a partition is already not counted as an opener, and I plan to complete
> hide the open count from the device driver.
I agree that this proposal exposes controls to userspace that simply
shouldn't be meaningful given the arbitrary nature of openers. And
preventing openers can result in a race where systemd or some other
service opens before the intended primary consumer of the device.
Seriously brittle and even if finely tuned to have a suitable value
for some niche usecase like android: an absolute hack.
Sorry, not interested in taking this.
prev parent reply other threads:[~2022-02-22 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 15:02 [PATCH] dm: introduce a no open flag for deferred remove Brian Geffon
2022-01-24 15:14 ` Alasdair G Kergon
2022-01-24 15:25 ` Brian Geffon
2022-01-25 0:20 ` Alasdair G Kergon
2022-01-25 14:25 ` Brian Geffon
2022-01-25 17:11 ` Brian Geffon
2022-01-26 19:22 ` [PATCH] dm: introduce a DM_ENFORCE_OPEN_COUNT flag Brian Geffon
2022-01-31 14:17 ` Brian Geffon
2022-02-02 14:42 ` Christoph Hellwig
2022-02-22 19:16 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhU2faRZJ4NstJ6L@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=bgeffon@google.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).