From: "mka@chromium.org" <mka@chromium.org>
To: "Tao Wang (Consultant) (QUIC)" <quic_wat@quicinc.com>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dianders@chromium.org" <dianders@chromium.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"hadess@hadess.net" <hadess@hadess.net>,
"krzk@kernel.org" <krzk@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"peter.chen@kernel.org" <peter.chen@kernel.org>,
"ravisadineni@chromium.org" <ravisadineni@chromium.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"rogerq@kernel.org" <rogerq@kernel.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"swboyd@chromium.org" <swboyd@chromium.org>,
"Linyu Yuan (QUIC)" <quic_linyyuan@quicinc.com>
Subject: Re: 回复: Re: [PATCH v20 3/5] usb: misc: Add onboard_usb_hub driver
Date: Tue, 22 Feb 2022 08:37:20 -0800 [thread overview]
Message-ID: <YhURQAksLKVuzU36@google.com> (raw)
In-Reply-To: <SA1PR02MB860660B6F33011E5A97F7930903A9@SA1PR02MB8606.namprd02.prod.outlook.com>
On Mon, Feb 21, 2022 at 06:20:00AM +0000, Tao Wang (Consultant) (QUIC) wrote:
> Hi,
>
>
>
> Regarding on board hub driver,
>
> [1]https://lore.kernel.org/linux-usb/20220119124327.v20.3.I7c9a1f1d6ced
> 41dd8310e8a03da666a32364e790@changeid/#R
>
>
> I have one comment below,
>
>
> +static const struct usb_device_id onboard_hub_id_table[] = {
>
> + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0411) }, /* RTS5411 USB 3.1
> */
>
> + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5411) }, /* RTS5411 USB 2.1
> */
>
> + { USB_DEVICE(VENDOR_ID_REALTEK, 0x0414) }, /* RTS5414 USB 3.2
> */
>
> + { USB_DEVICE(VENDOR_ID_REALTEK, 0x5414) }, /* RTS5414 USB 2.1
> */
>
> + {}
>
> +};
>
> +MODULE_DEVICE_TABLE(usb, onboard_hub_id_table);
>
>
> Can we support read VID/PID from device tree which provide platfrom
> device info?
As far as I understand the kernel exclusively uses the VID/PID reported by
the USB device, the compatible string in the device tree is purely
informational (though this driver uses it for the platform device).
next parent reply other threads:[~2022-02-22 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SA1PR02MB86067ACF0C96F18B7306D208903A9@SA1PR02MB8606.namprd02.prod.outlook.com>
[not found] ` <SA1PR02MB860660B6F33011E5A97F7930903A9@SA1PR02MB8606.namprd02.prod.outlook.com>
2022-02-22 16:37 ` mka [this message]
2022-02-23 7:40 ` 回复: 回复: Re: [PATCH v20 3/5] usb: misc: Add onboard_usb_hub driver Tao Wang (Consultant) (QUIC)
2022-02-23 7:56 ` gregkh
2022-02-28 3:08 ` Linyu Yuan (QUIC)
2022-02-28 18:28 ` mka
2022-03-01 2:30 ` Linyu Yuan (QUIC)
2022-03-01 16:33 ` mka
2022-03-02 5:14 ` Linyu Yuan (QUIC)
2022-03-04 16:47 ` mka
2022-03-07 1:24 ` Linyu Yuan (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhURQAksLKVuzU36@google.com \
--to=mka@chromium.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=michal.simek@xilinx.com \
--cc=peter.chen@kernel.org \
--cc=quic_linyyuan@quicinc.com \
--cc=quic_wat@quicinc.com \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).