From: Tejun Heo <tj@kernel.org>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, bristot@redhat.com,
zhaolei@cn.fujitsu.com, lizefan.x@bytedance.com,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
Minye Zhu <zhuminye@bytedance.com>
Subject: Re: [PATCH v3 1/3] sched/cpuacct: fix charge percpu cpuusage
Date: Tue, 22 Feb 2022 08:01:51 -1000 [thread overview]
Message-ID: <YhUlD+NUMYdKB40J@slm.duckdns.org> (raw)
In-Reply-To: <20220220051426.5274-1-zhouchengming@bytedance.com>
On Sun, Feb 20, 2022 at 01:14:24PM +0800, Chengming Zhou wrote:
> The cpuacct_account_field() is always called by the current task
> itself, so it's ok to use __this_cpu_add() to charge the tick time.
>
> But cpuacct_charge() maybe called by update_curr() in load_balance()
> on a random CPU, different from the CPU on which the task is running.
> So __this_cpu_add() will charge that cputime to a random incorrect CPU.
>
> Fixes: 73e6aafd9ea8 ("sched/cpuacct: Simplify the cpuacct code")
> Reported-by: Minye Zhu <zhuminye@bytedance.com>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
For all three patches,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2022-02-22 18:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 5:14 [PATCH v3 1/3] sched/cpuacct: fix charge percpu cpuusage Chengming Zhou
2022-02-20 5:14 ` [PATCH v3 2/3] sched/cpuacct: optimize away RCU read lock Chengming Zhou
2022-03-01 15:24 ` [tip: sched/core] sched/cpuacct: Optimize " tip-bot2 for Chengming Zhou
[not found] ` <CGME20220308232034eucas1p2b0f39cee0f462af6004ebdfbe5bacb9f@eucas1p2.samsung.com>
2022-03-08 23:20 ` [PATCH v3 2/3] sched/cpuacct: optimize " Marek Szyprowski
2022-03-08 23:32 ` Peter Zijlstra
2022-03-08 23:44 ` Paul E. McKenney
2022-03-09 0:21 ` Paul E. McKenney
2022-03-10 8:45 ` Peter Zijlstra
2022-03-10 15:01 ` Paul E. McKenney
2022-03-12 12:15 ` Peter Zijlstra
2022-03-12 17:44 ` Paul E. McKenney
2022-03-09 3:08 ` [External] " Chengming Zhou
2022-02-20 5:14 ` [PATCH v3 3/3] sched/cpuacct: remove redundant " Chengming Zhou
2022-03-01 15:24 ` [tip: sched/core] sched/cpuacct: Remove " tip-bot2 for Chengming Zhou
[not found] ` <CGME20220308233107eucas1p119a2f5a8d4f5b5eec38ea8dde92b3368@eucas1p1.samsung.com>
2022-03-08 23:31 ` [PATCH v3 3/3] sched/cpuacct: remove " Marek Szyprowski
2022-02-22 18:01 ` Tejun Heo [this message]
2022-02-23 9:11 ` [PATCH v3 1/3] sched/cpuacct: fix charge percpu cpuusage Peter Zijlstra
2022-03-01 15:24 ` [tip: sched/core] sched/cpuacct: Fix " tip-bot2 for Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhUlD+NUMYdKB40J@slm.duckdns.org \
--to=tj@kernel.org \
--cc=bristot@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=zhaolei@cn.fujitsu.com \
--cc=zhouchengming@bytedance.com \
--cc=zhuminye@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).