From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C43C433F5 for ; Wed, 23 Feb 2022 15:42:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242265AbiBWPnI (ORCPT ); Wed, 23 Feb 2022 10:43:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242341AbiBWPnA (ORCPT ); Wed, 23 Feb 2022 10:43:00 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF93927CC4 for ; Wed, 23 Feb 2022 07:42:32 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id o8so1510607pgf.9 for ; Wed, 23 Feb 2022 07:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5eKMkbn3vkPpm7UY1+T/n4u23dYrThYK2hTdMcTSqbk=; b=iQzHOuBdRTgUUwt6x2XL6c8dfG05Yq2gL7QStu4+rU71gTwZCdVG62tkmnrcJ/f8dH zQcDF4w85f82eNBReN8+eMUSdqm5waegLQY0IJNLiNjN36p+1FuyVSmEaSe7kUixtrVV VB1yF9AAN0VGCT3TMx+zfqBN2hQ1DdRRM7EcMByLGE+QkDfDbbN2X8+o+i4np2ejbMbL Znzp7xrygfK0NJmiU89eEIQGozNaVvTJUs6eEHx/+tBNY7jg4mQrXTTQU4EmoCMkCRYP htRsgSUx6DkOhgpD32eQl1emvmhW19tNmjDmqL+Js+IARGf+990k4VCkK+vyZfmRlbTy k5mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5eKMkbn3vkPpm7UY1+T/n4u23dYrThYK2hTdMcTSqbk=; b=adLhJwe6SPh6fhHLxuuL6ieN/V8qT/nF31ekp0W1yKl5cbgb7q5SXC8I5aaih1JQQl mUdLy/k6w0ZHDVOR3RkGH2LAH8GAK/D8nZECCCPn8rvoUt4S0WzPib5Z8p6+6wbMy1dx PLVvP4VbxOICCbOj/7luG2inZspAUVA25TF1/xKnHlCQDLvMoagmPfrtcjIDj7AbxHWq A2BPOvXTC4Riqm1VATe5q9+2TQCwXI5JNIJwfy/LEyYEfdOKrUNK5S83JHWPZrjZyO3l PzDCmmL/ebmUslshrz3uHjAT0ZxiGFh8zEOfbVAe+49yIhd8lD9NHzoCZXwwXdsRFZof IzCA== X-Gm-Message-State: AOAM533lLUXEzy80igqD1r+x5v6cubulvYv2DVoa7dXdWF7T27vH/qm1 FzX/o6ZQoDNqGtPg62z9lyIMNFP27wktmQ== X-Google-Smtp-Source: ABdhPJwC6BFJXKTBBXCtBd1U+4hyOlzH0X/agA3nwjmP1Umj4h9d1LMS/fMMYwwkm2ORUHx4O6X1YA== X-Received: by 2002:a62:fb0d:0:b0:4f1:a584:71f with SMTP id x13-20020a62fb0d000000b004f1a584071fmr10767700pfm.2.1645630951771; Wed, 23 Feb 2022 07:42:31 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id s24sm24789695pgq.51.2022.02.23.07.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 07:42:31 -0800 (PST) Date: Wed, 23 Feb 2022 15:42:27 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 05/18] KVM: x86/mmu: use struct kvm_mmu_root_info for mmu->root Message-ID: References: <20220217210340.312449-1-pbonzini@redhat.com> <20220217210340.312449-6-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 23, 2022, Maxim Levitsky wrote: > On Thu, 2022-02-17 at 16:03 -0500, Paolo Bonzini wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index b912eef5dc1a..c0d7256e3a78 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -762,7 +762,7 @@ bool kvm_inject_emulated_page_fault(struct kvm_vcpu *vcpu, > > if ((fault->error_code & PFERR_PRESENT_MASK) && > > !(fault->error_code & PFERR_RSVD_MASK)) > > kvm_mmu_invalidate_gva(vcpu, fault_mmu, fault->address, > > - fault_mmu->root_hpa); > > + fault_mmu->root.hpa); > > > > fault_mmu->inject_page_fault(vcpu, fault); > > return fault->nested_page_fault; > > > As a follow up to this patch I suggest that we should also rename pgd to just 'gpa'. Hmm, I prefer 'pgd' over 'gpa' because it provides a hint/reminder that the field is unused for TDP. It also pairs with e.g. kvm_mmu_new_pgd(), though I suppose we could rename those to something else too. > This also brings a question, what pgd acronym actually means? > I guess paging guest directory? Page Global Directory, borrowed from the kernel's arch-agnostic paging terminology.