From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD28C433FE for ; Thu, 24 Feb 2022 10:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233227AbiBXKLD (ORCPT ); Thu, 24 Feb 2022 05:11:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231709AbiBXKLB (ORCPT ); Thu, 24 Feb 2022 05:11:01 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C531F28ADAA; Thu, 24 Feb 2022 02:10:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 29E4BCE1E45; Thu, 24 Feb 2022 10:10:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D42F9C340E9; Thu, 24 Feb 2022 10:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1645697428; bh=Rbl59oRX72XEvYwduAiG46oni5FfUh7CH/lIFzuSQmI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jRzeWfMj4/o4gepA6Rbve+jREISZVsplcM6NNL1j56HPyR/Je377tGbtpHYiCJzKn MhgOuos+08MmdaipiV2aSLbFjxwnz49A2SEbz2ODZGY1XxnW6Dl34ACwTLBS0Funbq n1/MVO0MlY1L7qshvBmVoUnyrOJ3wLNDlAiRVEiE= Date: Thu, 24 Feb 2022 11:10:20 +0100 From: Greg KH To: Jiri Slaby Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] tty: serial: define UART_LCR_WLEN() macro Message-ID: References: <20220224095517.30872-1-jslaby@suse.cz> <20220224095558.30929-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220224095558.30929-1-jslaby@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 24, 2022 at 10:55:54AM +0100, Jiri Slaby wrote: > Define a generic UART_LCR_WLEN() macro with a size argument. It can be > used to encode byte size into an LCR value. Therefore we can use it to > simplify the drivers using tty_get_char_size() in the next patches. > > Signed-off-by: Jiri Slaby > --- > include/uapi/linux/serial_reg.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h > index f51bc8f36813..c9d5ff6dd4c6 100644 > --- a/include/uapi/linux/serial_reg.h > +++ b/include/uapi/linux/serial_reg.h > @@ -111,6 +111,7 @@ > #define UART_LCR_WLEN6 0x01 /* Wordlength: 6 bits */ > #define UART_LCR_WLEN7 0x02 /* Wordlength: 7 bits */ > #define UART_LCR_WLEN8 0x03 /* Wordlength: 8 bits */ > +#define UART_LCR_WLEN(x) ((x) - 5) I'm all for this, but why does it need to be in a uapi .h file? thanks, greg k-h