From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Cc: "Zhang, Qiang1" <qiang1.zhang@intel.com>,
Tejun Heo <tj@kernel.org>,
syzbot <syzbot+348b571beb5eeb70a582@syzkaller.appspotmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"syzkaller-bugs@googlegroups.com"
<syzkaller-bugs@googlegroups.com>,
"balbi@kernel.org" <balbi@kernel.org>
Subject: Re: [syzbot] KASAN: use-after-free Read in dev_uevent
Date: Sat, 26 Feb 2022 10:07:02 +0100 [thread overview]
Message-ID: <Yhnttj7dA0ZecNj0@kroah.com> (raw)
In-Reply-To: <Yhj7FO3hisW9yJRN@rowland.harvard.edu>
On Fri, Feb 25, 2022 at 10:51:48AM -0500, stern@rowland.harvard.edu wrote:
> On Fri, Feb 25, 2022 at 09:53:35AM +0100, gregkh@linuxfoundation.org wrote:
> > On Thu, Feb 24, 2022 at 09:06:13PM -0500, stern@rowland.harvard.edu wrote:
> > > On Thu, Feb 24, 2022 at 11:37:39PM +0100, gregkh@linuxfoundation.org wrote:
> > > > On Thu, Feb 24, 2022 at 04:23:26PM -0500, stern@rowland.harvard.edu wrote:
> > > > > Can you tell us how this should be fixed?
> > > >
> > > > It should be fixed by properly using the driver core to bind/unbind the
> > > > driver to devices like I mentioned previously :)
> > >
> > > This would involve creating a "gadget" bus_type (or should it be a
> > > device_type under the platform bus?) and registering the gadgets
> > > on it, right?.
> >
> > Yes. Or you can use the aux bus for this, which might be easier.
> >
> > > Similarly, the gadget drivers would be registered on
> > > this bus. I suppose we can control which drivers get bound to which
> > > gadgets with careful matching code.
> >
> > The aux bus might make this easier:
> > Documentation/driver-api/auxiliary_bus.rst
>
> Won't this end up changing the user-visible filenames and directories in
> sysfs for gadgets and gadget drivers?
>
> For instance, currently gadgets get registered under their UDC driver
> name, like "net2280" or "at91". If we put them on the aux bus then they
> will have to get registered under a name looking something like
> "udc.gadget.0", i.e., module name, generic device name, and ID number.
Ah, yeah, that isn't good.
> We will be forced to use a generic device name because the aux bus does
> matching based on it, and we want every gadget driver to be able to
> match every UDC. We don't want some gadget drivers restricted to
> net2280 gadgets, others restricted to fotg210 gadgets, and so on.
So yes, I guess it does need to be a "real" bus, sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2022-02-26 9:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 5:48 KASAN: use-after-free Read in dev_uevent syzbot
2022-02-20 17:19 ` [syzbot] " syzbot
2022-02-23 6:51 ` Zhang, Qiang1
2022-02-23 7:13 ` gregkh
2022-02-23 8:08 ` Zhang, Qiang1
2022-02-23 11:17 ` Zhang, Qiang1
2022-02-23 11:23 ` Pavel Skripkin
2022-02-23 11:27 ` Pavel Skripkin
2022-02-23 11:29 ` gregkh
2022-02-23 14:38 ` stern
2022-02-23 16:00 ` gregkh
2022-02-23 16:34 ` stern
2022-02-24 1:44 ` Zhang, Qiang1
2022-02-24 3:14 ` Zhang, Qiang1
2022-02-24 21:23 ` stern
2022-02-24 22:37 ` gregkh
2022-02-25 2:06 ` stern
2022-02-25 8:53 ` gregkh
2022-02-25 15:51 ` stern
2022-02-26 9:07 ` gregkh [this message]
2022-03-02 19:10 ` stern
2022-03-02 21:36 ` gregkh
2022-02-25 1:45 ` Zhang, Qiang1
[not found] <20220223233323.2104-1-hdanton@sina.com>
2022-02-24 0:09 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhnttj7dA0ZecNj0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang1.zhang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+348b571beb5eeb70a582@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).