From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v4 7/7] usb: typec: mux: Add On Semi fsa4480 driver
Date: Mon, 7 Mar 2022 12:16:35 +0200 [thread overview]
Message-ID: <YiXbg4QwgIgLh3LW@smile.fi.intel.com> (raw)
In-Reply-To: <20220307034040.1111107-7-bjorn.andersson@linaro.org>
On Sun, Mar 06, 2022 at 07:40:40PM -0800, Bjorn Andersson wrote:
> The ON Semiconductor FSA4480 is a USB Type-C port multimedia switch with
> support for analog audio headsets. It allows sharing a common USB Type-C
> port to pass USB2.0 signal, analog audio, sideband use wires and analog
> microphone signal.
>
> Due to lacking upstream audio support for testing, the audio muxing is
> left untouched, but implementation of muxing the SBU lines is provided
> as a pair of Type-C mux and switch devices. This provides the necessary
> support for enabling the DisplayPort altmode on devices with this
> circuit.
...
> +static const struct regmap_config fsa4480_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = FSA4480_MAX_REGISTER,
> +};
You are using mutex for accessing hardware. Do you still need a regmap lock?
If so, add a comment to explain why.
...
> + /* 15us to allow the SBU switch to turn off */
> + usleep_range(15, 1000);
This is quite unusual range.
If you are fine with the long delay, why to stress the system on it?
Otherwise the use of 1000 is unclear.
That said, I would expect one of the below:
usleep_range(15, 30);
usleep_range(500, 1000);
...
> + sw_desc.fwnode = dev->fwnode;
Please, don't dereference for fwnode explicitly. Use dev_fwnode().
...
> + mux_desc.fwnode = dev->fwnode;
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-07 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 3:40 [PATCH v4 1/7] device property: Helper to match multiple connections Bjorn Andersson
2022-03-07 3:40 ` [PATCH v4 2/7] device property: Use multi-connection matchers for single case Bjorn Andersson
2022-03-07 3:40 ` [PATCH v4 3/7] usb: typec: mux: Check dev_set_name() return value Bjorn Andersson
2022-03-07 10:08 ` Andy Shevchenko
2022-03-07 14:33 ` Bjorn Andersson
2022-03-07 14:52 ` Heikki Krogerus
2022-03-07 3:40 ` [PATCH v4 4/7] usb: typec: mux: Introduce indirection Bjorn Andersson
2022-03-07 3:40 ` [PATCH v4 5/7] usb: typec: mux: Allow multiple mux_devs per mux Bjorn Andersson
2022-03-07 3:40 ` [PATCH v4 6/7] dt-bindings: usb: Add binding for fcs,fsa4480 Bjorn Andersson
2022-03-07 3:40 ` [PATCH v4 7/7] usb: typec: mux: Add On Semi fsa4480 driver Bjorn Andersson
2022-03-07 10:16 ` Andy Shevchenko [this message]
2022-03-07 14:48 ` Bjorn Andersson
2022-03-07 16:13 ` Andy Shevchenko
2022-03-07 21:04 ` Bjorn Andersson
2022-03-07 22:13 ` Andy Shevchenko
2022-03-08 0:01 ` Bjorn Andersson
2022-03-07 10:05 ` [PATCH v4 1/7] device property: Helper to match multiple connections Andy Shevchenko
2022-03-07 19:13 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiXbg4QwgIgLh3LW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).