From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Daniel Scally" <djrscally@gmail.com>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>, "Nuno Sá" <nuno.sa@analog.com>
Subject: Re: [PATCH v3 1/1] device property: Allow error pointer to be passed to fwnode APIs
Date: Tue, 8 Mar 2022 14:22:06 +0200 [thread overview]
Message-ID: <YidKbrRq16NV+zNl@smile.fi.intel.com> (raw)
In-Reply-To: <Yic6yr6aycu7IHHh@paasikivi.fi.intel.com>
On Tue, Mar 08, 2022 at 01:15:22PM +0200, Sakari Ailus wrote:
> Hi Andy,
>
> This makes secondary handling quite a big nicer, thanks!
You are welcome!
> A few comments below. Apart from that,
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Thanks!
...
> On Mon, Mar 07, 2022 at 10:29:49PM +0200, Andy Shevchenko wrote:
> > #include <linux/acpi.h>
> > #include <linux/export.h>
> > +#include <linux/fwnode.h>
>
> Is this intended? linux/property.h already includes linux/fwnode.h.
>
> > #include <linux/kernel.h>
> > #include <linux/of.h>
> > #include <linux/of_address.h>
Yeah, this is a bit messy in the headers. I will drop the inclusion,
but in the future it would be good to reshuffle property.h, fwnode.h,
and perhaps extract swnode.h.
...
> > bool ret;
> >
> > + if (IS_ERR_OR_NULL(fwnode))
> > + return false;
> > + if (ret == true)
>
> It's already bool. I'd instead use:
>
> if (ret)
Right, will amend this.
> > + return ret;
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-03-08 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 20:29 [PATCH v3 1/1] device property: Allow error pointer to be passed to fwnode APIs Andy Shevchenko
2022-03-08 9:25 ` Sa, Nuno
2022-03-08 10:09 ` Andy Shevchenko
2022-03-08 10:32 ` Sa, Nuno
2022-03-08 11:15 ` Sakari Ailus
2022-03-08 12:22 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YidKbrRq16NV+zNl@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).