From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A18D6C433F5 for ; Wed, 9 Mar 2022 10:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231452AbiCIKtc (ORCPT ); Wed, 9 Mar 2022 05:49:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230327AbiCIKt1 (ORCPT ); Wed, 9 Mar 2022 05:49:27 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 121B3289AC; Wed, 9 Mar 2022 02:48:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 034EF617B1; Wed, 9 Mar 2022 10:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CECB5C340EE; Wed, 9 Mar 2022 10:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646822907; bh=nszSjITz7rc7Q6JPajiseDT3RQeb+PqXIqoDG287umc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XAy5RrXMWqdY/7u9anICI2tCq8ALHSmRv4LahQG9SqlzIf0xs5/HYTP0qiW8jA2WC NtQwdYdzfUFXT2Yty8EEg6nrH20qkmE00mPfQ9b4Z5iUwxBA0y30wlXZBf7eehYKt8 tjaeRYkiDUjZFrw43J07xlWBTGwWPJi1VPuUAdC0= Date: Wed, 9 Mar 2022 11:48:23 +0100 From: Greg KH To: Jonathan McDowell Cc: Dmitrii Okunev , Hans de Goede , Mark Gross , Qiaowei Ren , Matthew Garrett , Xiaoyan Zhang , Pavel Machek , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" Subject: Re: [RFC PATCH] platform/x86: Add sysfs interface for Intel TXT status Message-ID: References: <1368465884-14779-1-git-send-email-qiaowei.ren@intel.com> <1368465884-14779-3-git-send-email-qiaowei.ren@intel.com> <20130516160311.GA12299@amd.pavel.ucw.cz> <4febd50da7e5007a2797e0f4c969fa5edd0bf725.camel@fb.com> <20220217123753.GA21849@duo.ucw.cz> <0cf678e0b01bf421f3db6693a15ac4060501a80a.camel@fb.com> <20220222093101.GA23654@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 10:40:03AM +0000, Jonathan McDowell wrote: > (This is an RFC to see if the approach is generally acceptable; unlike > the previous driver this exposes the information purely as read-only > status information, so userspace can make an informed decision about the > system state without having to poke about in /dev/mem. There are still a > few extra registers I'm trying to dig up information for before a proper > submission.) > > This module provides read-only access to the Intel TXT (Trusted > Execution Technology) status registers, allowing userspace to determine > the status of measured boot and whether the dynamic root of trust for > measurement (DRTM) has been fully enabled. > > Tools such as txt-stat from tboot > can make use of this driver to > display state rather than relying on access to /dev/mem. > > See Documentation/x86/intel_txt.rst for more information about Intel > TXT. > > Signed-off-by: Jonathan McDowell > --- > arch/x86/include/asm/txt.h | 34 +++++ > drivers/platform/x86/intel/Kconfig | 14 ++ > drivers/platform/x86/intel/Makefile | 2 + > drivers/platform/x86/intel/txt_sysfs.c | 185 +++++++++++++++++++++++++ No Documentation/ABI/ entry for your new sysfs entry? How can we evaluate if this is a good api then? Wait, I don't see any sysfs code in here, are you sure you sent a viable patch? confused, greg k-h