From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: cgel.zte@gmail.com, axboe@kernel.dk, viro@zeniv.linux.org.uk,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
Yang Yang <yang.yang29@zte.com.cn>,
Ran Xiaokai <ran.xiaokai@zte.com.cn>
Subject: Re: [PATCH] block/psi: remove PSI annotations from submit_bio
Date: Thu, 10 Mar 2022 12:31:26 -0500 [thread overview]
Message-ID: <Yio17pXawRuuVJFO@cmpxchg.org> (raw)
In-Reply-To: <Yiok1xi0Hqmh1fbi@infradead.org>
On Thu, Mar 10, 2022 at 08:18:31AM -0800, Christoph Hellwig wrote:
> On Thu, Mar 10, 2022 at 11:16:41AM -0500, Johannes Weiner wrote:
> > The first version did that, but it was sprawling and not well-received:
> >
> > https://lkml.org/lkml/2019/7/22/1261
>
> Well, Dave's comments are spot on. Except that we replaced it with
> something even more horrible and not something sensible as he suggested.
Confused. I changed it the way Dave suggested, to which he replied
"this is much cleaner and easier to maintain". Are we reading
different threads? Care to elaborate?
next prev parent reply other threads:[~2022-03-10 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 9:43 [PATCH] block/psi: remove PSI annotations from submit_bio cgel.zte
2022-03-09 19:18 ` Johannes Weiner
2022-03-10 6:46 ` Christoph Hellwig
2022-03-10 16:16 ` Johannes Weiner
2022-03-10 16:18 ` Christoph Hellwig
2022-03-10 17:31 ` Johannes Weiner [this message]
2022-03-16 3:59 ` CGEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yio17pXawRuuVJFO@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgel.zte@gmail.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=viro@zeniv.linux.org.uk \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).