From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [GIT PULL] locking changes for v5.18
Date: Fri, 25 Mar 2022 15:06:12 +0200 [thread overview]
Message-ID: <Yj2+RDmBGHto4+e/@smile.fi.intel.com> (raw)
In-Reply-To: <20220325122336.GQ8939@worktop.programming.kicks-ass.net>
On Fri, Mar 25, 2022 at 01:23:36PM +0100, Peter Zijlstra wrote:
> On Fri, Mar 25, 2022 at 01:41:25PM +0200, Andy Shevchenko wrote:
> > On Tue, Mar 22, 2022 at 03:58:47PM -0700, Linus Torvalds wrote:
> > > On Tue, Mar 22, 2022 at 3:20 PM Borislav Petkov <bp@alien8.de> wrote:
> > > >
> > > > Ah, you say build error because you have CONFIG_WERROR=y.
> > >
> > > EVERYBODY should have CONFIG_WERROR=y on at least x86-64 and other
> > > serious architectures, unless you have some completely random
> > > experimental (and broken) compiler.
> > >
> > > New compiler warnings are not acceptable.
> >
> > What about old one? I have already complained in the early discussion that
> > `make W=1 ...` is broken by this change. Enabling it without fixing
> > _existing_ warnings on W=1 is not suitable for somebody. Now, I have to
> > modify my configs to disable WERROR because of inability to built at all.
> >
> > (Yes, I understand that I may drop W=1, but that's not the point. since I
> > want to have clean builds of a new code on level 1 of warnings)
>
> It would be fairly easy to make scripts/Makefile.extrawarn strip out
> -Werror when W= is used.
Hmm... I can't achieve this, because it complains about recursive variable.
What helped me is to supply in such case -Wno-error which seems overrode
the previous setting.
I'll send a patch to discuss further if needed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-25 13:06 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 11:11 [GIT PULL] locking changes for v5.18 Ingo Molnar
2022-03-22 22:05 ` Linus Torvalds
2022-03-22 22:19 ` Borislav Petkov
2022-03-22 22:58 ` Linus Torvalds
2022-03-23 7:11 ` Sebastian Andrzej Siewior
2022-03-23 11:09 ` [PATCH] locking/local_lock: Pretend to use the per-CPU variable if not needed Sebastian Andrzej Siewior
2022-03-23 17:17 ` Linus Torvalds
2022-03-24 17:39 ` [PATCH 0/3] Remove volatile from arch_raw_cpu_ptr() and revert the hacks Sebastian Andrzej Siewior
2022-03-24 17:39 ` [PATCH 1/3] x86/percpu: Remove volatile from arch_raw_cpu_ptr() Sebastian Andrzej Siewior
2022-03-24 17:39 ` [PATCH 2/3] Revert "locking/local_lock: Make the empty local_lock_*() function a macro." Sebastian Andrzej Siewior
2022-03-24 17:39 ` [PATCH 3/3] Revert "mm/page_alloc: mark pagesets as __maybe_unused" Sebastian Andrzej Siewior
2022-03-24 18:28 ` [PATCH 0/3] Remove volatile from arch_raw_cpu_ptr() and revert the hacks Linus Torvalds
2022-03-28 13:55 ` Peter Zijlstra
2022-03-28 14:59 ` Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 " Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 1/3] x86/percpu: Remove volatile from arch_raw_cpu_ptr() Sebastian Andrzej Siewior
2022-04-05 8:28 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 2/3] Revert "locking/local_lock: Make the empty local_lock_*() function a macro." Sebastian Andrzej Siewior
2022-04-05 8:28 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-28 14:58 ` [PATCH v2 3/3] Revert "mm/page_alloc: mark pagesets as __maybe_unused" Sebastian Andrzej Siewior
2022-04-05 8:28 ` [tip: locking/urgent] " tip-bot2 for Sebastian Andrzej Siewior
2022-03-23 11:21 ` [PATCH] x86/defconfig: Enable WERROR Borislav Petkov
2022-03-23 17:19 ` Linus Torvalds
2022-03-23 17:33 ` Borislav Petkov
2022-03-24 8:31 ` [PATCH] x86/config: Make the x86 defconfigs a bit more usable Ingo Molnar
2022-03-24 9:12 ` David Laight
2022-03-24 15:47 ` Nathan Chancellor
2022-03-25 11:52 ` Andy Shevchenko
2022-03-27 19:04 ` Ingo Molnar
2022-03-27 19:03 ` Ingo Molnar
2022-03-28 15:41 ` Nathan Chancellor
2022-09-02 8:50 ` Ingo Molnar
2022-09-02 9:18 ` Masahiro Yamada
2022-09-04 9:48 ` Ingo Molnar
2022-09-05 2:16 ` Masahiro Yamada
2022-09-05 9:54 ` Ingo Molnar
[not found] ` <CAK7LNAQyiNpbLuVjjQ8-GOQECtfQZqsNS8xH0E2ZkLAHYtXt7A@mail.gmail.com>
2022-09-10 17:28 ` Linus Torvalds
2022-03-24 8:16 ` [tip: x86/urgent] x86/defconfig: Enable WERROR tip-bot2 for Borislav Petkov
2022-03-25 11:41 ` [GIT PULL] locking changes for v5.18 Andy Shevchenko
2022-03-25 12:23 ` Peter Zijlstra
2022-03-25 13:06 ` Andy Shevchenko [this message]
2022-03-25 17:29 ` Linus Torvalds
2022-03-25 17:53 ` Andy Shevchenko
2022-03-22 22:38 ` Peter Zijlstra
2022-03-22 23:26 ` Linus Torvalds
2022-03-24 8:40 ` Ingo Molnar
2022-03-24 10:19 ` Borislav Petkov
2022-03-24 23:19 ` Nick Desaulniers
2022-03-22 23:27 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj2+RDmBGHto4+e/@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).