From: Greg KH <gregkh@linuxfoundation.org>
To: Manjunatha Venkatesh <manjunatha.venkatesh@nxp.com>
Cc: linux-kernel@vger.kernel.org, will@kernel.org, axboe@kernel.dk,
mb@lightnvm.io, ckeepax@opensource.cirrus.com, arnd@arndb.d,
mst@redhat.com, javier@javigon.com, mikelley@microsoft.com,
jasowang@redhat.com, sunilmut@microsoft.com,
bjorn.andersson@linaro.org, rvmanjumce@gmail.com
Subject: Re: [PATCH v2] uwb: nxp: sr1xx: UWB driver support for sr1xx series chip
Date: Tue, 15 Mar 2022 12:34:17 +0100 [thread overview]
Message-ID: <YjB5ue4nHUUVOW/8@kroah.com> (raw)
In-Reply-To: <20220315105205.2381997-1-manjunatha.venkatesh@nxp.com>
On Tue, Mar 15, 2022 at 04:22:05PM +0530, Manjunatha Venkatesh wrote:
> Ultra Wide Band(UWB) is a fast, secure and low power radio protocol used
> to determine location with accuracy unmatched by any other wireless
> technology.
The kernel changelog is not the place for marketing copy. Please just
describe the hardware without using words like this.
> Its a short-range wireless communication protocol. It uses radio waves to
> enable devices to talk to each other.
>
> This is a new driver that supports the integrated UWB for
> Nxp SoCs, especially the sr1xx series and depends on the SPI module.
>
> This driver works with Nxp UWB Subsystem(UWBS) which is FiRa Compliance.
> Corresponding UCI details available in Fira Consortuim website.
>
> sr1xx is flash less UWBS and it requires firmware download on every
> device boot.
>
> Internally driver will handle two modes of operation.
> 1.HBCI mode (sr1xx BootROM Code Interface)
> Firmware download uses HBCI ptotocol packet structure which is
> Nxp proprietary,Firmware File(.bin) stored in user space context
> and during device init sequence pick the firmware packet in chunk
> and send it to the driver with write() api call.
> Complete firmware download protocol logic implemented in user space,
> Driver used here is kind of pipe to send data to SPI line.
> Firmware acknowledge for every chunk packet sent and same thing
> is monitored,in user space code(HAL layer).
> If any error Firmware download sequence will fail and reset the device.
> If firmware download packet sent successfully at the end device will
> send device status notification and its indication of device entered
> UCI mode.Here after any command/response/notification will follow
> UCI packet structure.
>
> 2.UCI mode (UWB Command interface)
> Once Firmware download finishes sr1xx will switch to UCI mode packet
> structure.Here this driver acts as pipe between user space and sr1xx.
> Any response or notification received from sr1xx through SPI line
> will convey to user space.User space(UCI lib) will take care of
> UCI parsing logic.
Where is that userspace code? How will it talk to the kernel? Why do
the existing user/kernel apis not sufice for this one random hardware
device? We have support for wireless devices of all types today, why
is this so special it needs a custom interface for it?
>
> Its IRQ based driver and sr1xx specific irq handshake mechanism logic
> implemented to avoid any race condition between write and read
> during ranging sequence.
>
> UCI mode Write is same as HBCI mode sequence whatever command received
> from user space will send to the sr1xx via SPI line.
> In UCI mode read api called first and waiting on the IRQ line status
> in order to avoid missing of interrupts after write sequence.
>
> This driver needs dts config update as per the sr1xx data sheet.
> Corresponding document added in Documentation/devicetree/bindings/uwb
>
> Signed-off-by: Manjunatha Venkatesh <manjunatha.venkatesh@nxp.com>
>
> Changes since v1:
> https://lkml.org/lkml/2022/3/7/1254
> ---
> MAINTAINERS | 7 +
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/uwb/Kconfig | 27 ++
> drivers/uwb/Makefile | 5 +
> drivers/uwb/sr1xx.c | 857 +++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 899 insertions(+)
> create mode 100644 drivers/uwb/Kconfig
> create mode 100644 drivers/uwb/Makefile
> create mode 100644 drivers/uwb/sr1xx.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e127c2fb08a7..31c08ecc152c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21471,3 +21471,10 @@ S: Buried alive in reporters
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> F: *
> F: */
> +
> +UWB
> +M: Greg KH <gregkh@linuxfoundation.org>
Hah, NO!
> +M: manjunatha.venkatesh@nxp.com
> +L: rvmanjumce@gmail.com
Full names.
> +S: Maintained
> +F: drivers/uwb/sr1xx.c
This needs to be sorted properly. Please read the file you are
modifying.
I'm stopping here. Don't add anyone's name to a MAINTAINERS file unless
you get explicit permission from them to do so. Otherwise it is quite
rude, don't you think?
{sigh}
greg k-h
next prev parent reply other threads:[~2022-03-15 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 10:52 [PATCH v2] uwb: nxp: sr1xx: UWB driver support for sr1xx series chip Manjunatha Venkatesh
2022-03-15 11:34 ` Greg KH [this message]
2022-03-15 13:10 ` [EXT] " Manjunatha Venkatesh
2022-03-15 11:34 ` Greg KH
2022-03-15 11:12 Manjunatha Venkatesh
2022-03-15 11:39 ` Greg KH
2022-03-15 19:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjB5ue4nHUUVOW/8@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.d \
--cc=axboe@kernel.dk \
--cc=bjorn.andersson@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=jasowang@redhat.com \
--cc=javier@javigon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manjunatha.venkatesh@nxp.com \
--cc=mb@lightnvm.io \
--cc=mikelley@microsoft.com \
--cc=mst@redhat.com \
--cc=rvmanjumce@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).