From: Lee Jones <lee.jones@linaro.org>
To: frank zago <frank@zago.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Jan-Niklas Burfeind <kernel@aiyionpri.me>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Wolfram Sang <wsa@kernel.org>, Johan Hovold <johan@kernel.org>,
linux-usb@vger.kernel.org, gunar@schorcht.net
Subject: Re: [PATCH v3] mfd: ch341: add driver for the WCH CH341 in I2C/GPIO mode
Date: Tue, 15 Mar 2022 14:58:51 +0000 [thread overview]
Message-ID: <YjCpq8YVwmZzOzwE@google.com> (raw)
In-Reply-To: <20220314030937.22762-1-frank@zago.net>
On Sun, 13 Mar 2022, frank zago wrote:
> The CH341 is a multifunction chip, presenting 3 different USB PID. One
> of these functions is for I2C/SPI/GPIO. This new driver manages I2C
> and GPIO.
>
> The I2C interface can run at 4 different speeds. This driver currently
> only offer 100MHz. Tested with a variety of I2C sensors, and the IIO
> subsystem.
>
> The GPIO interface offers 16 GPIOs. 6 are read/write, and 10 are
> read-only.
>
> Signed-off-by: frank zago <frank@zago.net>
> ---
>
> Changes from v2:
> - bug fixes
> - more robust USB enumeration
> - Changed to an MFD driver as suggested
Perhaps you should have engaged with me before potentially wasting
your valuable time.
MFD is designed to take a parent platform driver and split it out into
various sub-systems. If you don't use the MFD Core API (which is the
case here) it is not an MFD. MFD is not a dumping ground for
collections of random device drivers.
I have no problem with you placing registration and core code inside
MFD (that *is* what it was designed for), but the leaf 'functionality'
should be placed in more appropriate locations.
I2C => drivers/i2c
SPI => drivers/spi
GPIO => drivers/gpio (or perhaps drivers/pinctrl)
USB => drivers/usb
UART => drivers/tty/serial
Etc ... Find places for everything.
Anything left over, give to Greg (drivers/misc). :)
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-03-15 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 3:09 [PATCH v3] mfd: ch341: add driver for the WCH CH341 in I2C/GPIO mode frank zago
2022-03-14 15:52 ` kernel test robot
2022-03-14 20:18 ` kernel test robot
2022-03-15 14:30 ` Greg Kroah-Hartman
2022-03-15 14:58 ` Lee Jones [this message]
2022-03-16 3:48 ` Frank Zago
2022-03-16 7:29 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjCpq8YVwmZzOzwE@google.com \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=frank@zago.net \
--cc=gregkh@linuxfoundation.org \
--cc=gunar@schorcht.net \
--cc=johan@kernel.org \
--cc=kernel@aiyionpri.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).