From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-spi <linux-spi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [GIT PULL] SPI fixes for v5.17-rc7
Date: Wed, 16 Mar 2022 16:26:44 +0000 [thread overview]
Message-ID: <YjIPxMrt5rzQ2AtQ@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdWd_eAGjXRAODXvufoXT_QqqOpuLJTAj9ZG7d-EQyRKBw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Tue, Mar 15, 2022 at 07:56:13PM +0100, Geert Uytterhoeven wrote:
> You're absolutely right. So the code should be changed to:
>
> if (vmalloced_buf || kmap_buf) {
> - desc_len = min_t(unsigned int, max_seg_size, PAGE_SIZE);
> + desc_len = min_t(unsigned long, max_seg_size, PAGE_SIZE);
> sgs = DIV_ROUND_UP(len + offset_in_page(buf), desc_len);
> } else if (virt_addr_valid(buf)) {
> - desc_len = min_t(unsigned int, max_seg_size, ctlr->max_dma_len);
> + desc_len = min_t(size_t, max_seg_size, ctlr->max_dma_len);
> sgs = DIV_ROUND_UP(len, desc_len);
> } else {
> return -EINVAL;
> }
Can you send a patch please?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-16 16:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 12:13 [GIT PULL] SPI fixes for v5.17-rc7 Mark Brown
2022-03-10 12:25 ` Linus Torvalds
2022-03-10 12:47 ` Mark Brown
2022-03-15 9:08 ` Geert Uytterhoeven
2022-03-15 16:48 ` Linus Torvalds
2022-03-15 18:56 ` Geert Uytterhoeven
2022-03-16 16:26 ` Mark Brown [this message]
2022-03-16 17:54 ` Biju Das
2022-03-10 12:27 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjIPxMrt5rzQ2AtQ@sirena.org.uk \
--to=broonie@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).