From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45EDCC433EF for ; Mon, 21 Mar 2022 08:23:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345217AbiCUIZJ (ORCPT ); Mon, 21 Mar 2022 04:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345206AbiCUIZC (ORCPT ); Mon, 21 Mar 2022 04:25:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01C05FE1; Mon, 21 Mar 2022 01:23:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 08053B81145; Mon, 21 Mar 2022 08:23:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A6E1C340E8; Mon, 21 Mar 2022 08:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1647851013; bh=Cfz3f9Iw/dbsqO3pWGoIxGQSFuUQvmLff9oW734nUSo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0gQ+ZQZAjVysYCaO3ADO4mYtthm6nqM3Ax2qySTJZFtuEfSV1u9OEwujRcu3Z4y29 kr+Z6Qv1DqRoitFm1r53pVDwJkEttnjviddGI2xMBZIaqLilNVZX7iodrwz4WipY/i ivoxO80ikjHRFW4MVTfm8JV/Dx+2rzb1RI2iOQIA= Date: Mon, 21 Mar 2022 09:23:30 +0100 From: Greg Kroah-Hartman To: Quan Nguyen Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Jean Delvare , Guenter Roeck , Jonathan Corbet , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Thu Nguyen , Gustavo Pimentel , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:HARDWARE MONITORING" , "open list:DOCUMENTATION" , OpenBMC Maillist , Open Source Submission , Phong Vo , "Thang Q . Nguyen" Subject: Re: [PATCH v7 9/9] docs: ABI: testing: Document the Ampere Altra Family's SMpro sysfs interfaces Message-ID: References: <20220321081355.6802-1-quan@os.amperecomputing.com> <20220321081355.6802-10-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321081355.6802-10-quan@os.amperecomputing.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 03:13:55PM +0700, Quan Nguyen wrote: > Add documentation for the Ampere(R)'s Altra(R) SMpro sysfs interfaces > > Signed-off-by: Quan Nguyen > --- > Changes in v7: > + First introduce in v7 [Greg] > > .../sysfs-bus-platform-devices-ampere-smpro | 133 ++++++++++++++++++ > 1 file changed, 133 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro > > diff --git a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro > new file mode 100644 > index 000000000000..9bfd8d6d0f71 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro > @@ -0,0 +1,133 @@ > +What: /sys/bus/platform/devices/smpro-errmon.*/errors_[core|mem|pcie|other]_[ce|ue] Please split this out as one entry per file. > +KernelVersion: 5.14 5.14 is a long time ago. > +Contact: quan@os.amperecomputing.com > +Description: > + (RO) Contains the 48-byte Ampere (Vendor-Specific) Error Record, see [1] > + printed in hex format as below: > + > + AA BB CCCC DDDDDDDD DDDDDDDDDDDDDDDD DDDDDDDDDDDDDDDD \ > + DDDDDDDDDDDDDDDD DDDDDDDDDDDDDDDD DDDDDDDDDDDDDDDD > + Where: > + AA : Error Type > + BB : Subtype > + CCCC : Instance > + DDD...DDD: Similar to the Arm RAS standard error record No, this is not a valid sysfs file, sorry. This should just be one value per file. > + > + See [1] below for the format details. > + > + The detail of each sysfs entries is as below: > + +-------------+---------------------------------------------------------+ > + | Error | Sysfs entry | > + +-------------+---------------------------------------------------------+ > + | Core's CE | /sys/bus/platform/devices/smpro-errmon.*/errors_core_ce | > + | Core's UE | /sys/bus/platform/devices/smpro-errmon.*/errors_core_ue | > + | Memory's CE | /sys/bus/platform/devices/smpro-errmon.*/errors_mem_ce | > + | Memory's UE | /sys/bus/platform/devices/smpro-errmon.*/errors_mem_ue | > + | PCIe's CE | /sys/bus/platform/devices/smpro-errmon.*/errors_pcie_ce | > + | PCIe's UE | /sys/bus/platform/devices/smpro-errmon.*/errors_pcie_ue | > + | Other's CE | /sys/bus/platform/devices/smpro-errmon.*/errors_other_ce| > + | Other's UE | /sys/bus/platform/devices/smpro-errmon.*/errors_other_ue| > + +-------------+---------------------------------------------------------+ > + UE: Uncorrect-able Error > + CE: Correct-able Error > + > + [1] Section 3.3 Ampere (Vendor-Specific) Error Record Formats, > + Altra Family RAS Supplement. > + > + > +What: /sys/bus/platform/devices/smpro-errmon.*/errors_[smpro|pmpro] > +KernelVersion: 5.14 > +Contact: quan@os.amperecomputing.com > +Description: > + (RO) Contains the internal firmware error record printed as hex format > + as below: > + > + A BB C DD EEEE FFFFFFFF Again this isn't a good sysfs entry. You should never have to parse a sysfs file except for a single value. thanks, greg k-h