From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: broonie@kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linmq006@gmail.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com,
matthias.bgg@gmail.com, aaronyu@google.com,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset
Date: Mon, 21 Mar 2022 17:21:44 +0800 [thread overview]
Message-ID: <YjhDqKhtYastPhf0@google.com> (raw)
In-Reply-To: <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com>
On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote:
> On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote:
> > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote:
> > > @@ -1145,6 +1140,13 @@ static int mt8192_mt6359_dev_probe(struct
> > > platform_device *pdev)
> > > goto err_speaker_codec;
> > > }
> > >
> > > + headset_codec = of_get_child_by_name(pdev->dev.of_node,
> > > "mediatek,headset-codec");
> > > + if (!headset_codec) {
> > > + ret = -EINVAL;
> > > + dev_err_probe(&pdev->dev, ret, "Property
> > > 'headset_codec' missing or invalid\n");
> > > + goto err_headset_codec;
> > > + }
> >
> > (to be neat) Does it have any reason to prevent from using
> > of_parse_phandle()
> > but of_get_child_by_name()?
>
> "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I use
> of_get_child_by_name() to get and pass it to
> snd_soc_of_get_dai_link_codecs().
"mediatek,platform" and "mediatek,hdmi-codec" are also children of
pdev->dev.of_node. I guess my question is: why doesn't it also use
of_parse_phandle() for "mediatek,headset-codec"? Did I misunderstand?
next prev parent reply other threads:[~2022-03-21 9:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-19 11:41 [v5 0/4] ASoC: mediatek: mt8192: support rt1015p_rt5682s Jiaxin Yu
2022-03-19 11:41 ` [v5 1/4] ASoC: dt-bindings: mt8192-mt6359: add new compatible and new properties Jiaxin Yu
2022-03-21 23:33 ` Rob Herring
2022-03-22 3:45 ` Jiaxin Yu
2022-03-22 15:02 ` Rob Herring
2022-03-19 11:41 ` [v5 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker Jiaxin Yu
2022-03-21 3:59 ` Tzung-Bi Shih
2022-03-21 15:24 ` Tzung-Bi Shih
2022-03-19 11:41 ` [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset Jiaxin Yu
2022-03-21 3:59 ` Tzung-Bi Shih
2022-03-21 9:14 ` Jiaxin Yu
2022-03-21 9:21 ` Tzung-Bi Shih [this message]
2022-03-21 14:38 ` Jiaxin Yu
2022-03-21 15:23 ` Tzung-Bi Shih
2022-03-21 15:24 ` Tzung-Bi Shih
2022-03-19 11:41 ` [v5 4/4] ASoC: mediatek: mt8192: support rt1015p_rt5682s Jiaxin Yu
2022-03-21 3:59 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjhDqKhtYastPhf0@google.com \
--to=tzungbi@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=trevor.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).