From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6407AC433F5 for ; Mon, 21 Mar 2022 14:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349272AbiCUOZ2 (ORCPT ); Mon, 21 Mar 2022 10:25:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352549AbiCUOWi (ORCPT ); Mon, 21 Mar 2022 10:22:38 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14343186897 for ; Mon, 21 Mar 2022 07:16:35 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id v75so16362318oie.1 for ; Mon, 21 Mar 2022 07:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QH3AWcYu7AkrcxCD+1AyJsqFqXIRrhSBVQz3h8P5LfU=; b=a6jbebu58k8yNzCyy4LCvlCQfQ5EzUFQADfFplTD2dfiDuiewpP7F1xnW4RRu/3Hl2 Neot+S3ZbVaxnTtRDhtUsIZ0HDQ7KFpEdw++9id9UisJ+P1+wlkUbdOr+Wo7Fhiz/YSx Gsz5gzPENQPO4Pv5fQIjyAe3t2x/eCF0rGlxm1ER6f/99PTPtcM7xkKkMOqWw6Sjq2YI J12f/TWMw9dUxicqEYP7RNMREIqVgf7ElH+0hDXNpZCnD7pmg4MjSHa3/t4cIcdQIqIm ZHDJlecpJAwyR71E0IPtlqUKPzedq/5+2dX+vBxD2XI8YVqqmfu6joNwPe7YTGhvPPYN 2OFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QH3AWcYu7AkrcxCD+1AyJsqFqXIRrhSBVQz3h8P5LfU=; b=Z35tC3iLFvtFp+qXlLpEvETzLsn7ZanAaHwc7PHdyXNEQYpAIrFcICyTT4NoqtuS58 dys3RcC4HA2pM5MVRAFIa6ZOz37rofjO8fk93gMSIMFdG8ItSrYz1+Srfrw1ABUzUw13 TORJX9e4+K1miUcSwYf5AomZoNz9Naf1W1kMB6Q23BWwht4S3KX+YshTlyJlrDkMdr2y Z8T203PTgdMb9JLJDhbTKqQrTHMTK6nireoj1/FdIrqSNyZ+F048ocS6ds5PGtpLFHeI uqFSq+jlbWJF0Pj7QyC9G6Kh7Ju1rMl2yYjxorKE/w/ZxYPovfUy2uI6JmZQQw7hbUq9 RbTg== X-Gm-Message-State: AOAM531Jf23AUphMtDsnwWUq3bBvvmjFGLU0DpB0EF6y8LIGOPwIiqRp wumWC2rOpUQwIyEw99RvXdA8Xw== X-Google-Smtp-Source: ABdhPJxr4m2fEljzSzrW1Im9R0W5tgP6mwWuY4H+a54HyaHHJTHSHL/qeGghCZ3NUXyPTdlVO8s+JQ== X-Received: by 2002:a05:6808:47:b0:2ec:bddc:c677 with SMTP id v7-20020a056808004700b002ecbddcc677mr13705279oic.250.1647872190940; Mon, 21 Mar 2022 07:16:30 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id j9-20020a056830270900b005b22854f3besm7439539otu.39.2022.03.21.07.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 07:16:29 -0700 (PDT) Date: Mon, 21 Mar 2022 09:16:27 -0500 From: Bjorn Andersson To: Krzysztof Kozlowski Cc: Andy Gross , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss Subject: Re: [RFT] ufs: qcom: drop custom Android boot parameters Message-ID: References: <20220320110616.18355-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220320110616.18355-1-krzk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 20 Mar 06:06 CDT 2022, Krzysztof Kozlowski wrote: > The QCOM UFS driver requires an androidboot.bootdevice command line > argument matching the UFS device name. If the name is different, it > refuses to probe. Thise androidboot.bootdevice is provided by > stock/vendor (from an Android-based device) bootloader. > > This does not make sense from Linux point of view. Driver should be > able to boot regardless of bootloader. Driver should not depend on some > Android custom environment data. > > Cc: Luca Weiss > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Bjorn Andersson > --- > > Not tested, please kindly provide tests. > > See also: > https://lore.kernel.org/linux-devicetree/f61abc2b-3ce8-7b1f-3d28-8a4a03ec58eb@kernel.org/T/#u > --- > drivers/scsi/ufs/ufs-qcom.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 0d2e950d0865..586c0e567ff9 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -957,18 +957,6 @@ static const struct reset_control_ops ufs_qcom_reset_ops = { > .deassert = ufs_qcom_reset_deassert, > }; > > -#define ANDROID_BOOT_DEV_MAX 30 > -static char android_boot_dev[ANDROID_BOOT_DEV_MAX]; > - > -#ifndef MODULE > -static int __init get_android_boot_dev(char *str) > -{ > - strlcpy(android_boot_dev, str, ANDROID_BOOT_DEV_MAX); > - return 1; > -} > -__setup("androidboot.bootdevice=", get_android_boot_dev); > -#endif > - > /** > * ufs_qcom_init - bind phy with controller > * @hba: host controller instance > @@ -988,9 +976,6 @@ static int ufs_qcom_init(struct ufs_hba *hba) > struct resource *res; > struct ufs_clk_info *clki; > > - if (strlen(android_boot_dev) && strcmp(android_boot_dev, dev_name(dev))) > - return -ENODEV; > - > host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); > if (!host) { > err = -ENOMEM; > -- > 2.32.0 >