From: Thierry Reding <treding@nvidia.com>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
rafael@kernel.org, viresh.kumar@linaro.org, robh+dt@kernel.org,
krzk+dt@kernel.org, linux-pm@vger.kernel.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, ksitaraman@nvidia.com,
sanjayc@nvidia.com, bbasu@nvidia.com
Subject: Re: [Patch v1 2/3] arm64: tegra: add node for tegra234 cpufreq
Date: Mon, 21 Mar 2022 16:48:46 +0100 [thread overview]
Message-ID: <YjiQ9DThcWuKiHhj@orome> (raw)
In-Reply-To: <748d87c6-3f91-8bc0-ce8f-0a64278b4122@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2113 bytes --]
On Mon, Mar 21, 2022 at 06:24:21PM +0530, Sumit Gupta wrote:
>
>
> > > Adding cclpex node to represent Tegra234 cpufreq.
> > > Tegra234 uses some of the CRAB (Control Register Access Bus)
> > > registers for cpu frequency requests. These registers are
> > > memory mapped to CCPLEX_MMCRAB_ARM region. In this node, mapping
> > > the range of MMCRAB registers required only for cpu frequency info.
> > >
> > > Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> > > ---
> > > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > > b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > > index aaace605bdaa..610207f3f967 100644
> > > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > > @@ -1258,6 +1258,13 @@
> > > };
> > > };
> > > + ccplex@e000000 {
> > > + compatible = "nvidia,tegra234-ccplex-cluster";
> > > + reg = <0x0 0x0e000000 0x0 0x5ffff>;
> > > + nvidia,bpmp = <&bpmp>;
> > > + status = "okay";
> > > + };
> > > +
> > > sram@40000000 {
> > > compatible = "nvidia,tegra234-sysram", "mmio-sram";
> > > reg = <0x0 0x40000000 0x0 0x80000>;
> >
> >
> > We need to add this compatible string to a DT binding doc somewhere.
> It seems the binding doc was previously posted in [1] for T186 SoC.
> Same will be applicable for T234 SoC also. Only compatible string need to be
> added.
> Should I sent a separate patch after converting it to yaml format and add
> compatible string (or) send as part of v2.
>
> [1] https://lkml.org/lkml/2017/4/3/324
Yeah, it's probably best to pick up Mikko's patch, convert the bindings
to YAML and then make the addition of the Tegra234 compatible string a
separate patch on top of that. Alternatively you may want to add the
compatible string while doing the conversion since it's just a one-line
change.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-21 15:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 13:58 [Patch v1 0/3] Tegra234 cpufreq driver support Sumit Gupta
2022-03-16 13:58 ` [Patch v1 1/3] cpufreq: tegra194: add soc data to support multiple soc Sumit Gupta
2022-03-16 13:58 ` [Patch v1 2/3] arm64: tegra: add node for tegra234 cpufreq Sumit Gupta
2022-03-18 8:39 ` Jon Hunter
2022-03-21 12:54 ` Sumit Gupta
2022-03-21 15:48 ` Thierry Reding [this message]
2022-03-16 13:58 ` [Patch v1 3/3] cpufreq: tegra194: Add support for Tegra234 Sumit Gupta
2022-03-22 5:50 ` Viresh Kumar
2022-03-22 12:06 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjiQ9DThcWuKiHhj@orome \
--to=treding@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ksitaraman@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sanjayc@nvidia.com \
--cc=sumitg@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).