From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [PATCH v2 2/2] mfd: arizona-spi: Add Android board ACPI table handling
Date: Tue, 22 Mar 2022 07:20:31 +0000 [thread overview]
Message-ID: <Yjl4v/Cg3iSQdzIY@google.com> (raw)
In-Reply-To: <20220307173844.199135-2-hdegoede@redhat.com>
On Mon, 07 Mar 2022, Hans de Goede wrote:
> x86/ACPI boards with an arizona WM5102 codec ship with either Windows or
> Android as factory installed OS.
>
> The ACPI fwnode for the codec on Android boards misses 2 things compared
> to the Windows boards (this is hardcoded in the Android board kernels):
>
> 1. There is no CLKE ACPI method to enabe the 32 KHz clock the codec needs
> for jack-detection.
>
> 2. The GPIOs used by the codec are not listed in the fwnode for the codec.
>
> The ACPI tables on x86/ACPI boards shipped with Android being incomplete
> happens a lot. The special drivers/platform/x86/x86-android-tablets.c
> module contains DMI based per model handling to compensate for this.
>
> This module will enable the 32KHz clock through the pinctrl framework
> to fix 1. and it will also register a gpio-lookup table for all GPIOs
> needed by the codec + machine driver, including the GPIOs coming from
> the codec itself.
>
> Add an arizona_spi_acpi_android_probe() function which waits for the
> x86-android-tablets to have set things up before continue with probing
> the arizona WM5102 codec.
>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> - Wrap long dev_info_once() line
> ---
> drivers/mfd/arizona-spi.c | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-03-22 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 17:38 [PATCH v2 1/2] mfd: arizona-spi: Split Windows ACPI init code into its own function Hans de Goede
2022-03-07 17:38 ` [PATCH v2 2/2] mfd: arizona-spi: Add Android board ACPI table handling Hans de Goede
2022-03-22 7:20 ` Lee Jones [this message]
2022-03-22 7:19 ` [PATCH v2 1/2] mfd: arizona-spi: Split Windows ACPI init code into its own function Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjl4v/Cg3iSQdzIY@google.com \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).