From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Asias He <asias@redhat.com>,
Arseny Krasnov <arseny.krasnov@kaspersky.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v3 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them
Date: Thu, 24 Mar 2022 09:20:30 +0000 [thread overview]
Message-ID: <Yjw33hb1u4Da6pKK@stefanha-x1.localdomain> (raw)
In-Reply-To: <20220323173625.91119-1-sgarzare@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
On Wed, Mar 23, 2022 at 06:36:22PM +0100, Stefano Garzarella wrote:
> The first patch fixes a virtio-spec violation. The other two patches
> complete the driver configuration before using the VQs in the probe.
>
> The patch order should simplify backporting in stable branches.
>
> v3:
> - re-ordered the patch to improve bisectability [MST]
>
> v2: https://lore.kernel.org/netdev/20220323084954.11769-1-sgarzare@redhat.com/
> v1: https://lore.kernel.org/netdev/20220322103823.83411-1-sgarzare@redhat.com/
>
> Stefano Garzarella (3):
> vsock/virtio: initialize vdev->priv before using VQs
> vsock/virtio: read the negotiated features before using VQs
> vsock/virtio: enable VQs early on probe
>
> net/vmw_vsock/virtio_transport.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> --
> 2.35.1
>
A subtle point is that we still drop events and rx packets during the
window where DRIVER_OK has been set but vqs haven't been filled.
This is acceptable because it's unavoidable and equivalent to events
happening before DRIVER_OK is set. What this revision *does* fix is that
vq used buffer notifications are no longer lost. Good.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-24 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 17:36 [PATCH net v3 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them Stefano Garzarella
2022-03-23 17:36 ` [PATCH net v3 1/3] vsock/virtio: initialize vdev->priv before using VQs Stefano Garzarella
2022-03-23 17:36 ` [PATCH net v3 2/3] vsock/virtio: read the negotiated features " Stefano Garzarella
2022-03-23 17:36 ` [PATCH net v3 3/3] vsock/virtio: enable VQs early on probe Stefano Garzarella
2022-03-23 22:37 ` [PATCH net v3 0/3] vsock/virtio: enable VQs early on probe and finish the setup before using them Michael S. Tsirkin
2022-03-24 9:20 ` Stefan Hajnoczi [this message]
2022-03-25 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjw33hb1u4Da6pKK@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=arseny.krasnov@kaspersky.com \
--cc=asias@redhat.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).