From: Rob Herring <robh@kernel.org>
To: Sui Jingfeng <15330273260@189.cn>
Cc: Qing Zhang <zhangqing@loongson.cn>,
David Airlie <airlied@linux.ie>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
kernel test robot <lkp@intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
devicetree@vger.kernel.org, suijingfeng <suijingfeng@loongson.cn>,
Thomas Zimmermann <tzimmermann@suse.de>,
Roland Scheidegger <sroland@vmware.com>,
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
dri-devel@lists.freedesktop.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller
Date: Thu, 24 Mar 2022 08:56:25 -0500 [thread overview]
Message-ID: <Yjx4iSkddTNo7q7K@robh.at.kernel.org> (raw)
In-Reply-To: <2aa26f44-38aa-4b3c-ccc3-0956a2ab5d77@189.cn>
On Thu, Mar 24, 2022 at 03:32:01PM +0800, Sui Jingfeng wrote:
>
> On 2022/3/23 04:49, Rob Herring wrote:
> > > + }
> > > +
> > > + spin_lock_init(&li2c->reglock);
> > > +
> > > + snprintf(compat, sizeof(compat), "lsdc,i2c-gpio-%d", index);
> > compatible values shouldn't have an index and you shouldn't need a
> > index in DT. You need to iterate over child nodes with matching
> > compatible.
>
> Why compatible values shouldn't have an index, does devicetree
> specification prohibit this? [1]
Probably not explicitly, but that's fundamentally not how compatible
works. 'compatible' defines WHAT the device is, not WHICH device and
that is used for matching devices to drivers. Drivers work on multiple
instances.
> The recommended format is "manufacturer,model", where manufacturer is a string describing the name
> of the manufacturer (such as a stock ticker symbol), and model specifies the model number. [1]
I don't see anything saying to put the instance in there, do you?
>
> [1] https://www.devicetree.org/specifications/
>
next prev parent reply other threads:[~2022-03-24 13:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 16:29 [PATCH v11 0/7] drm/lsdc: add drm driver for loongson display controller Sui Jingfeng
2022-03-21 16:29 ` [PATCH v11 1/7] MIPS: Loongson64: dts: update the display controller device node Sui Jingfeng
2022-03-21 16:29 ` [PATCH v11 2/7] MIPS: Loongson64: dts: introduce ls3A4000 evaluation board Sui Jingfeng
2022-03-22 13:05 ` Jiaxun Yang
2022-03-22 13:38 ` Sui Jingfeng
2022-03-22 16:06 ` Jiaxun Yang
2022-03-23 1:53 ` Sui Jingfeng
2022-03-23 2:29 ` Jiaxun Yang
2022-03-23 3:07 ` Sui Jingfeng
2022-03-23 3:14 ` Jiaxun Yang
2022-03-23 7:07 ` Sui Jingfeng
2022-03-23 12:29 ` Jiaxun Yang
2022-03-23 12:53 ` Rob Herring
2022-03-24 1:51 ` Sui Jingfeng
2022-03-21 16:29 ` [PATCH v11 3/7] MIPS: Loongson64: dts: introduce lemote A1901 motherboard Sui Jingfeng
2022-03-21 16:29 ` [PATCH v11 4/7] MIPS: Loongson64: dts: introduce ls2k1000 pai evaluation board Sui Jingfeng
2022-03-21 16:29 ` [PATCH v11 5/7] dt-bindings: display: Add Loongson display controller Sui Jingfeng
2022-03-21 23:20 ` Rob Herring
2022-03-22 2:33 ` Sui Jingfeng
2022-03-22 13:08 ` Jiaxun Yang
2022-03-22 13:54 ` Sui Jingfeng
2022-03-22 16:08 ` Jiaxun Yang
2022-03-22 20:03 ` Rob Herring
2022-03-22 20:55 ` Rob Herring
2022-03-23 3:38 ` Sui Jingfeng
2022-03-23 13:03 ` Rob Herring
2022-03-24 1:48 ` Sui Jingfeng
2022-03-24 13:26 ` Rob Herring
2022-03-26 10:04 ` Sui Jingfeng
2022-03-28 14:04 ` Rob Herring
2022-03-29 2:02 ` Sui Jingfeng
2022-03-29 13:24 ` Rob Herring
2022-03-21 16:29 ` [PATCH v11 6/7] MIPS: Loongson64: defconfig: enable display bridge drivers on Loongson64 Sui Jingfeng
2022-03-21 16:29 ` [PATCH v11 7/7] drm/lsdc: add drm driver for loongson display controller Sui Jingfeng
2022-03-22 20:49 ` Rob Herring
2022-03-23 4:12 ` Sui Jingfeng
2022-03-23 13:11 ` Rob Herring
2022-03-24 4:05 ` Sui Jingfeng
2022-04-08 2:09 ` Sui Jingfeng
2022-03-23 4:19 ` Sui Jingfeng
2022-03-23 8:49 ` Sui Jingfeng
2022-03-23 9:31 ` Sui Jingfeng
2022-03-24 1:39 ` Sui Jingfeng
2022-03-24 13:42 ` Rob Herring
2022-03-24 7:32 ` Sui Jingfeng
2022-03-24 13:56 ` Rob Herring [this message]
2023-01-17 3:08 ` Sui jingfeng
2023-02-03 2:48 ` suijingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjx4iSkddTNo7q7K@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=15330273260@189.cn \
--cc=airlied@linux.ie \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sam@ravnborg.org \
--cc=sroland@vmware.com \
--cc=suijingfeng@loongson.cn \
--cc=tsbogend@alpha.franken.de \
--cc=tzimmermann@suse.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).