From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62818C433EF for ; Thu, 24 Mar 2022 11:10:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349673AbiCXLM2 (ORCPT ); Thu, 24 Mar 2022 07:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244414AbiCXLM1 (ORCPT ); Thu, 24 Mar 2022 07:12:27 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 689C565D2C; Thu, 24 Mar 2022 04:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648120255; x=1679656255; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mKNGXFCV4Kp8qwJN+GNi3JImHKbQI1aeqMv/NpYMBAU=; b=H2iU3EecJU2mI5sKw673Q3N9VvUA0bgwsMBlvgaTv8fbbWw3QcOSijHI 4PjG+vLzpYFaeGqg92fjy+Lga0MT9sbAbrilE0hAnnNo9bLVgOSxVFl6e phoYZ54ycW3WXHAPpuRPxMH462mYK+SyWKXHVVgPhTxb4rwzs4BV+Q12r y7/Nv6skBQd7cgazBXRwOxwb+4XWEeB0jlZr0AxwOwxW0P9FEFRAp0Swb UDj0S7BOqZ+qYzKQz5c5+H//11K53tuOVtD0FD9t3cM4OcFdIJA/wQt8f fl6K9b+pB2pvGGD2Jf7A9PQWgQ44dR9nvsnSmtWcTKNsr6ndEcVJh+vTB Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10295"; a="240506670" X-IronPort-AV: E=Sophos;i="5.90,207,1643702400"; d="scan'208";a="240506670" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2022 04:10:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,207,1643702400"; d="scan'208";a="501354888" Received: from boxer.igk.intel.com (HELO boxer) ([10.102.20.173]) by orsmga003.jf.intel.com with ESMTP; 24 Mar 2022 04:10:51 -0700 Date: Thu, 24 Mar 2022 12:10:51 +0100 From: Maciej Fijalkowski To: Marcin Szycik Cc: Ivan Vecera , netdev@vger.kernel.org, poros@redhat.com, mschmidt@redhat.com, Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Brett Creeley , Jeff Kirsher , "moderated list:INTEL ETHERNET DRIVERS\"" , open list Subject: Re: [PATCH net] ice: Clear default forwarding VSI during VSI release Message-ID: References: <20220322142554.3253428-1-ivecera@redhat.com> <45b155ff-8e26-fa96-f89e-6a561de01abb@linux.intel.com> <20220323185426.33c66892@ceranb> <287f2247-2c58-497d-f7b1-ae1e24a88da8@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <287f2247-2c58-497d-f7b1-ae1e24a88da8@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 23, 2022 at 07:19:55PM +0100, Marcin Szycik wrote: > > > On 23-Mar-22 18:54, Ivan Vecera wrote: > > On Wed, 23 Mar 2022 18:39:11 +0100 > > Marcin Szycik wrote: > > > >> On 22-Mar-22 15:25, Ivan Vecera wrote: > >>> VSI is set as default forwarding one when promisc mode is set for > >>> PF interface, when PF is switched to switchdev mode or when VF > >>> driver asks to enable allmulticast or promisc mode for the VF > >>> interface (when vf-true-promisc-support priv flag is off). > >>> The third case is buggy because in that case VSI associated with > >>> VF remains as default one after VF removal. > >>> > >>> Reproducer: > >>> 1. Create VF > >>> echo 1 > sys/class/net/ens7f0/device/sriov_numvfs > >>> 2. Enable allmulticast or promisc mode on VF > >>> ip link set ens7f0v0 allmulticast on > >>> ip link set ens7f0v0 promisc on > >>> 3. Delete VF > >>> echo 0 > sys/class/net/ens7f0/device/sriov_numvfs > >>> 4. Try to enable promisc mode on PF > >>> ip link set ens7f0 promisc on > >>> > >>> Although it looks that promisc mode on PF is enabled the opposite > >>> is true because ice_vsi_sync_fltr() responsible for IFF_PROMISC > >>> handling first checks if any other VSI is set as default forwarding > >>> one and if so the function does not do anything. At this point > >>> it is not possible to enable promisc mode on PF without re-probe > >>> device. > >>> > >>> To resolve the issue this patch clear default forwarding VSI tiny nit: s/clear/clears Also it's more welcome to use imperative mood. > >>> during ice_vsi_release() when the VSI to be released is the default > >>> one. > >>> > >>> Fixes: 01b5e89aab49 ("ice: Add VF promiscuous support") > >>> Signed-off-by: Ivan Vecera > >>> --- > >>> drivers/net/ethernet/intel/ice/ice_lib.c | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >>> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c > >>> index 53256aca27c7..20d755822d43 100644 > >>> --- a/drivers/net/ethernet/intel/ice/ice_lib.c > >>> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c > >>> @@ -3147,6 +3147,8 @@ int ice_vsi_release(struct ice_vsi *vsi) > >>> } > >>> } > >>> > >>> + if (ice_is_vsi_dflt_vsi(pf->first_sw, vsi)) > >>> + ice_clear_dflt_vsi(pf->first_sw); > >> > >> It would probably be good to check `ice_clear_dflt_vsi` return code. > > > > Check and report potential warning when error occurs? because we are in ice_vsi_release() so > > any rollback does not make sense. I believe that comment wouldn't hurt that it's ok to ignore the retval, but then again i'm fine with what it is currently :) Reviewed-by: Maciej Fijalkowski > > Right. ice_clear_dflt_vsi already reports errors so it should be good as is. > LGTM, thanks! > > > > > Ivan > >