From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FAEC4332F for ; Wed, 6 Apr 2022 22:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237166AbiDFWne (ORCPT ); Wed, 6 Apr 2022 18:43:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbiDFWnb (ORCPT ); Wed, 6 Apr 2022 18:43:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D41D9D95C8; Wed, 6 Apr 2022 15:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+WIA2q0pmyXTrZ0eOlA9UZBi8s5TS5ILt11uq0tkv4M=; b=gpwnf3R91zYcnEE8S+QFl4Pyj8 rO/0fZBeKQ9GsdWtpD5cre6S+irKUoOhJ5bq4HUb5K4rxkIGv8ZNMc0LFhRgT6tSnUjC802MqJeK+ gmHC2v4eKWMX9ajIkyiJtB7oT+DKpTysfX+CWNVo72qLKtczkUpOcp8hqTX4/3lJ+bj0yDrklmUGh KOPzXJv8WZthp74yQV7tIet98IgKZkvQLd6REiTjTRVk4lU2vX+jQykweMK2BDohchavVLXwywxij sLwEuCW7x5KC3ECovNLHguysxCA/06V9B9P0HnMW1vCiW0X/UGHpW/mDmQ+5h+KBVAFE9bFVw3Nci 0pQwyEOA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncEL5-0089eh-7f; Wed, 06 Apr 2022 22:41:23 +0000 Date: Wed, 6 Apr 2022 15:41:23 -0700 From: Luis Chamberlain To: Daniel Borkmann Cc: Yan Zhu , andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, john.fastabend@gmail.com, kafai@fb.com, keescook@chromium.org, kpsingh@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, liucheng32@huawei.com, netdev@vger.kernel.org, nixiaoming@huawei.com, songliubraving@fb.com, xiechengliang1@huawei.com, yhs@fb.com, yzaikin@google.com, zengweilin@huawei.com Subject: Re: [PATCH v3 sysctl-next] bpf: move bpf sysctls from kernel/sysctl.c to bpf module Message-ID: References: <20220302020412.128772-1-zhuyan34@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 03, 2022 at 04:23:26PM -0800, Luis Chamberlain wrote: > On Fri, Mar 04, 2022 at 12:44:48AM +0100, Daniel Borkmann wrote: > > On 3/2/22 9:39 PM, Luis Chamberlain wrote: > > > On Wed, Mar 02, 2022 at 10:04:12AM +0800, Yan Zhu wrote: > > > > We're moving sysctls out of kernel/sysctl.c as its a mess. We > > > > already moved all filesystem sysctls out. And with time the goal is > > > > to move all sysctls out to their own susbsystem/actual user. > > > > > > > > kernel/sysctl.c has grown to an insane mess and its easy to run > > > > into conflicts with it. The effort to move them out is part of this. > > > > > > > > Signed-off-by: Yan Zhu > > > > > > Daniel, let me know if this makes more sense now, and if so I can > > > offer take it through sysctl-next to avoid conflicts more sysctl knobs > > > get moved out from kernel/sysctl.c. > > > > If this is a whole ongoing effort rather than drive-by patch, > > It is ongoing effort, but it will take many releases before we tidy > this whole thing up. > > > then it's > > fine with me. > > OK great. Thanks for understanding the mess. > > > Btw, the patch itself should also drop the linux/bpf.h > > include from kernel/sysctl.c since nothing else is using it after the > > patch. > > I'll let Yan deal with that. Yan, feel free to resubmit based on sysctl-next [0]. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next Luis