linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Cc: outreachy@lists.linux.dev, Larry.Finger@lwfinger.net,
	florian.c.schilhabel@googlemail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: rtl8712: remove unnecessary parentheses
Date: Thu, 7 Apr 2022 20:28:39 +0200	[thread overview]
Message-ID: <Yk8tVxot2znwyWLm@kroah.com> (raw)
In-Reply-To: <96a1de63-5b66-b6a6-731e-d7263f3328a5@gmail.com>

On Thu, Apr 07, 2022 at 08:02:37PM +0200, Alaa Mohamed wrote:
> 
> On ٧‏/٤‏/٢٠٢٢ ١٩:٤٦, Greg KH wrote:
> > On Thu, Apr 07, 2022 at 02:59:47PM +0200, Alaa Mohamed wrote:
> > > Reported by checkpatch:
> > > 
> > > Remove unnecessary parentheses around structure field references
> > > 
> > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> > > ---
> > > Changes in v2:
> > > 	- Edit commit subject
> > > 	- Edit commit message
> > > 	- Fix the same check in more lines
> > > 	- Remove space before '.skey' in
> > > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86.
> > > ---
> > > Changes in v3:
> > > 	return the space before '.skey' in
> > > "memcpy(psta->tkiptxmickey.skey," in lines 84 and 86
> > > ---
> > > Changes in v4:
> > > 	edit commit message to be clearer.
> > > ---
> > Why did you send this patch twice?
> That was by mistake , sorry

When you do so, please let us know which to take, as it is hard to know
if there was a difference or not.

Realize that for some of us, we get hundreds of patches to review daily.
Being obvious as to what to, and not to, ignore, is helpful.

thanks,

greg k-h

  reply	other threads:[~2022-04-07 18:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 12:59 [PATCH v4] staging: rtl8712: remove unnecessary parentheses Alaa Mohamed
2022-04-07 17:46 ` Greg KH
2022-04-07 18:02   ` Alaa Mohamed
2022-04-07 18:28     ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-04-07 12:48 Alaa Mohamed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk8tVxot2znwyWLm@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=eng.alaamohamedsoliman.am@gmail.com \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).