From: Wolfram Sang <wsa@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Jean Delvare <jdelvare@suse.de>
Cc: linux-i2c@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Rosin <peda@axentia.se>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Terry Bowman <terry.bowman@amd.com>
Subject: Re: [PULL REQUEST] i2c for v5.18
Date: Mon, 28 Mar 2022 21:01:08 +0200 [thread overview]
Message-ID: <YkIF9OqbZQ8yinz8@ninjato> (raw)
In-Reply-To: <CAHk-=wgoeUc15-8Wu8U=4FnwhgmyU3C13R107oigbmJRpi_sZA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On Sat, Mar 26, 2022 at 12:58:36PM -0700, Linus Torvalds wrote:
> On Fri, Mar 25, 2022 at 1:28 AM Wolfram Sang <wsa@kernel.org> wrote:
> >
> > I2C has for 5.18: tracepoints when Linux acts as an I2C client, added
> > support for AMD PSP, whole subsytsem now uses generic_handle_irq_safe(),
> > piix4 driver gained MMIO access enabling so far missed controllers with
> > AMD chipsets, plus a bulk of device driver updates, refactorization, and
> > fixes.
>
> It feels odd/wrong to use the piix4 driver for the AMD MMIO case on SB800.
>
> Would it not have made more sense to just make that a separate driver?
>
> It feels like now the piix4 driver has a lot of "if SB800" for the
> probing code, and then a lot of "if (mmio)" at runtime.
>
> I've pulled this, but just wanted to mention this "that looks a bit
> odd". How much code is actually _shared_ in the SB800 case?
>
> I'm not insisting on splitting this up - maybe it all makes sense. I'm
> just questioning it.
Adding Jean to CC, he maintains the PC-style drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-03-28 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 8:28 [PULL REQUEST] i2c for v5.18 Wolfram Sang
2022-03-26 19:58 ` Linus Torvalds
2022-03-28 19:01 ` Wolfram Sang [this message]
2022-03-29 12:26 ` Jean Delvare
2022-03-29 22:10 ` Linus Torvalds
2022-03-26 20:18 ` pr-tracker-bot
2022-03-26 21:45 ` Linus Torvalds
2022-03-28 19:02 ` Wolfram Sang
2022-04-17 3:01 Wolfram Sang
2022-04-17 16:32 ` Linus Torvalds
2022-04-17 16:58 ` pr-tracker-bot
2022-05-22 15:23 Wolfram Sang
2022-05-22 18:08 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkIF9OqbZQ8yinz8@ninjato \
--to=wsa@kernel.org \
--cc=brgl@bgdev.pl \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=terry.bowman@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).