From: Matthew Wilcox <willy@infradead.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, mgorman@techsingularity.net
Subject: Re: [PATCH 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone
Date: Tue, 29 Mar 2022 03:22:51 +0100 [thread overview]
Message-ID: <YkJte/L4jZv47FOO@casper.infradead.org> (raw)
In-Reply-To: <20220329015230.hneciyfxoxtvfytl@master>
On Tue, Mar 29, 2022 at 01:52:30AM +0000, Wei Yang wrote:
> @@ -1985,14 +1985,13 @@ static bool migrate_balanced_pgdat(struct pglist_data *pgdat,
> continue;
>
> /* Avoid waking kswapd by allocating pages_to_migrate pages. */
> - if (!zone_watermark_ok(zone, 0,
> + if (zone_watermark_ok(zone, 0,
> high_wmark_pages(zone) +
> nr_migrate_pages,
> ZONE_MOVABLE, 0))
Someone's done the silly thing of lining up all of these with spaces,
so either all these lines also need to be shrunk by one space, or you
need to break that convention and just go to a reasonable number of
tabs. I'd do it like this:
if (zone_watermark_ok(zone, 0,
high_wmark_pages(zone) + nr_migrate_pages,
ZONE_MOVABLE, 0))
but not everybody would.
> @@ -2040,16 +2040,11 @@ static int numamigrate_isolate_page(pg_data_t *pgdat, struct page *page)
> return 0;
>
> /* Avoid migrating to a node that is nearly full */
> - if (!migrate_balanced_pgdat(pgdat, nr_pages)) {
> - int z;
> -
> + if ((zone = migrate_balanced_pgdat(pgdat, nr_pages))) {
Linus had a rant about this style recently. He much prefers:
zone = migrate_balanced_pgdat(pgdat, nr_pages);
if (zone) {
(the exception is for while loops:
while ((zone = migrate_balanced_pgdat(pgdat, nr_pages)) != NULL)
where he wants to see the comparison against NULL instead of the awkard
double-bracket)
next prev parent reply other threads:[~2022-03-29 2:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 2:41 [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Wei Yang
2022-03-27 2:41 ` [PATCH 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone Wei Yang
2022-03-28 1:08 ` Huang, Ying
2022-03-28 7:23 ` Miaohe Lin
2022-03-29 0:45 ` Wei Yang
2022-03-29 1:55 ` Miaohe Lin
2022-03-29 0:41 ` Wei Yang
2022-03-29 0:43 ` Huang, Ying
2022-03-29 1:52 ` Wei Yang
2022-03-29 2:05 ` Huang, Ying
2022-03-30 0:14 ` Wei Yang
2022-03-29 2:22 ` Matthew Wilcox [this message]
2022-03-29 23:59 ` Wei Yang
2022-03-28 7:11 ` [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones Miaohe Lin
2022-03-28 7:33 ` David Hildenbrand
2022-03-28 8:14 ` Oscar Salvador
2022-03-29 0:48 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkJte/L4jZv47FOO@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=richard.weiyang@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).