From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD78C433F5 for ; Tue, 29 Mar 2022 15:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238914AbiC2Pk4 (ORCPT ); Tue, 29 Mar 2022 11:40:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234581AbiC2Pkz (ORCPT ); Tue, 29 Mar 2022 11:40:55 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ECE111BD98; Tue, 29 Mar 2022 08:39:08 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-7-220-252.bstnma.fios.verizon.net [108.7.220.252]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 22TFcn3E001516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 11:38:50 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id AE79A15C3ECA; Tue, 29 Mar 2022 11:38:49 -0400 (EDT) Date: Tue, 29 Mar 2022 11:38:49 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Jason A. Donenfeld" , Dominik Brodowski , Greg Kroah-Hartman , Jean-Philippe Aumasson Subject: Re: [PATCH AUTOSEL 5.17 16/43] random: use computational hash for entropy extraction Message-ID: References: <20220328111828.1554086-1-sashal@kernel.org> <20220328111828.1554086-16-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2022 at 06:08:26PM +0000, Eric Biggers wrote: > On Mon, Mar 28, 2022 at 07:18:00AM -0400, Sasha Levin wrote: > > From: "Jason A. Donenfeld" > > > > [ Upstream commit 6e8ec2552c7d13991148e551e3325a624d73fac6 ] > > > > I don't think it's a good idea to start backporting random commits to random.c > that weren't marked for stable. There were a lot of changes in v5.18, and > sometimes they relate to each other in subtle ways, so the individual commits > aren't necessarily safe to pick. > > IMO, you shouldn't backport any non-stable-Cc'ed commits to random.c unless > Jason explicitly reviews the exact sequence of commits that you're backporting. Especially this commit in general, which is making a fundamental change in how we extract entropy. We should be very careful about taking such changes into stable; a release or two of additonal "soak" time would be a good idea before these go into the LTS releases in particular. - Ted