From: Rob Herring <robh@kernel.org>
To: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
Cc: andrew@lunn.ch, netdev@vger.kernel.org, olteanv@gmail.com,
UNGLinuxDriver@microchip.com, woojung.huh@microchip.com,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, linux-kernel@vger.kernel.org,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
devicetree@vger.kernel.org, pabeni@redhat.com
Subject: Re: [RFC PATCH v11 net-next 01/10] dt-bindings: net: make internal-delay-ps based on phy-mode
Date: Tue, 29 Mar 2022 15:41:24 -0500 [thread overview]
Message-ID: <YkNu9D24qu+tIP/n@robh.at.kernel.org> (raw)
In-Reply-To: <20220325165341.791013-2-prasanna.vengateshan@microchip.com>
On Fri, Mar 25, 2022 at 10:23:32PM +0530, Prasanna Vengateshan wrote:
> *-internal-delay-ps properties would be applicable only for RGMII interface
> modes.
>
> It is changed as per the request,
> https://lore.kernel.org/netdev/d8e5f6a8-a7e1-dabd-f4b4-ea8ea21d0a1d@gmail.com/
>
> Ran dt_binding_check to confirm nothing is broken.
>
> Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@microchip.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> .../bindings/net/ethernet-controller.yaml | 37 +++++++++++++------
> 1 file changed, 25 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 34c5463abcec..dc86a6479a86 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -123,12 +123,6 @@ properties:
> and is useful for determining certain configuration settings
> such as flow control thresholds.
>
> - rx-internal-delay-ps:
> - description: |
> - RGMII Receive Clock Delay defined in pico seconds.
> - This is used for controllers that have configurable RX internal delays.
> - If this property is present then the MAC applies the RX delay.
> -
> sfp:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -140,12 +134,6 @@ properties:
> The size of the controller\'s transmit fifo in bytes. This
> is used for components that can have configurable fifo sizes.
>
> - tx-internal-delay-ps:
> - description: |
> - RGMII Transmit Clock Delay defined in pico seconds.
> - This is used for controllers that have configurable TX internal delays.
> - If this property is present then the MAC applies the TX delay.
> -
> managed:
> description:
> Specifies the PHY management type. If auto is set and fixed-link
> @@ -222,6 +210,31 @@ properties:
> required:
> - speed
>
> +allOf:
> + - if:
> + properties:
> + phy-mode:
> + contains:
> + enum:
> + - rgmii
> + - rgmii-rxid
> + - rgmii-txid
> + - rgmii-id
> + then:
Did you test this?
The 'then' has no effect. It's at the wrong indentation. It should be
the same as 'if'.
> + properties:
> + rx-internal-delay-ps:
> + description:
> + RGMII Receive Clock Delay defined in pico seconds.This is
> + used for controllers that have configurable RX internal
> + delays. If this property is present then the MAC applies
> + the RX delay.
> + tx-internal-delay-ps:
> + description:
> + RGMII Transmit Clock Delay defined in pico seconds.This is
> + used for controllers that have configurable TX internal
> + delays. If this property is present then the MAC applies
> + the TX delay.
> +
> additionalProperties: true
>
> ...
> --
> 2.30.2
>
>
next prev parent reply other threads:[~2022-03-29 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 16:53 [RFC PATCH v11 net-next 00/10] net: dsa: microchip: DSA driver support for LAN937x switch Prasanna Vengateshan
2022-03-25 16:53 ` [RFC PATCH v11 net-next 01/10] dt-bindings: net: make internal-delay-ps based on phy-mode Prasanna Vengateshan
2022-03-29 20:41 ` Rob Herring [this message]
2022-03-25 16:53 ` [RFC PATCH v11 net-next 02/10] dt-bindings: net: dsa: dt bindings for microchip lan937x Prasanna Vengateshan
2022-04-08 22:40 ` Vladimir Oltean
2022-03-25 16:53 ` [RFC PATCH v11 net-next 03/10] net: dsa: move mib->cnt_ptr reset code to ksz_common.c Prasanna Vengateshan
2022-03-25 16:53 ` [RFC PATCH v11 net-next 04/10] net: dsa: tag_ksz: add tag handling for Microchip LAN937x Prasanna Vengateshan
2022-03-25 16:53 ` [RFC PATCH v11 net-next 05/10] net: dsa: microchip: add DSA support for microchip lan937x Prasanna Vengateshan
2022-04-08 23:25 ` Vladimir Oltean
2022-03-25 16:53 ` [RFC PATCH v11 net-next 06/10] net: dsa: microchip: add support for phylink management Prasanna Vengateshan
2022-04-08 23:41 ` Vladimir Oltean
2022-04-29 15:58 ` Russell King (Oracle)
2022-03-25 16:53 ` [RFC PATCH v11 net-next 07/10] net: dsa: microchip: add support for ethtool port counters Prasanna Vengateshan
2022-03-25 16:53 ` [RFC PATCH v11 net-next 08/10] net: dsa: microchip: add support for port mirror operations Prasanna Vengateshan
2022-03-25 16:53 ` [RFC PATCH v11 net-next 09/10] net: dsa: microchip: add support for fdb and mdb management Prasanna Vengateshan
2022-03-25 16:53 ` [RFC PATCH v11 net-next 10/10] net: dsa: microchip: add support for vlan operations Prasanna Vengateshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkNu9D24qu+tIP/n@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=prasanna.vengateshan@microchip.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).