From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0983BC433F5 for ; Wed, 30 Mar 2022 11:05:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343511AbiC3LHg (ORCPT ); Wed, 30 Mar 2022 07:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343490AbiC3LHf (ORCPT ); Wed, 30 Mar 2022 07:07:35 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6809E08B; Wed, 30 Mar 2022 04:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648638349; x=1680174349; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MYCryOcIAiX8RK8QwL575BHmStD3LWKxFVsGNh49MH4=; b=WS/r60a7PcZTSJ+PkTPqkf4D6IoyZsbahk25nJ4VaiaApd7GLGJqNkhe aqv3w9YhphpLPpLek58Eb15nNMTPLlKmjFNIABbIsuQnKLy6vhCDcGdz3 BtWKVKbOxSz+e56LvWnR0ry/iWhvaJ9FtbDBONAxrhjd816cgL52tCNut fcI5Qzt0Z87kYiZ5Ia9C4llDQ/CalhrvJay3/pklv3JYBIQHjwFjBgcIb w7+fGHmNH33TvnyvpW/7NXT0+0FTBh2y0a7x4PBPzqZND7pGCtmGwMwBP ljZEwjgQosjw+mOLZkY6izP2X2dEfKal9AVhihbRv0T5IIxNFhgo7VKvJ A==; X-IronPort-AV: E=McAfee;i="6200,9189,10301"; a="345952115" X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="345952115" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 04:05:49 -0700 X-IronPort-AV: E=Sophos;i="5.90,222,1643702400"; d="scan'208";a="719933391" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2022 04:05:47 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 97C3F20365; Wed, 30 Mar 2022 14:05:45 +0300 (EEST) Date: Wed, 30 Mar 2022 14:05:45 +0300 From: Sakari Ailus To: Laurent Pinchart Cc: Hangyu Hua , mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: mc: delete redundant code in __media_device_unregister_entity Message-ID: References: <20220324102752.47077-1-hbh25y@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2022 at 03:47:10PM +0200, Laurent Pinchart wrote: > Hi Hangyu, > > Thank you for the patch. > > On Thu, Mar 24, 2022 at 06:27:52PM +0800, Hangyu Hua wrote: > > media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to > > set it again. > > > > Signed-off-by: Hangyu Hua > > Reviewed-by: Laurent Pinchart > > > --- > > drivers/media/mc/mc-device.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c > > index cf5e459b1d96..7727c619043e 100644 > > --- a/drivers/media/mc/mc-device.c > > +++ b/drivers/media/mc/mc-device.c > > @@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity) > > > > /* invoke entity_notify callbacks to handle entity removal?? */ > > > > - entity->graph_obj.mdev = NULL; Removed the extra newline above, too. Applied. Please run scripts/checkpatch.pl on the patches, too. > > } > > > > /** > > -- > Regards, > > Laurent Pinchart -- Sakari Ailus