From: Luis Chamberlain <mcgrof@kernel.org>
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
Cc: corbet@lwn.net, keescook@chromium.org, yzaikin@google.com,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux@rasmusvillemoes.dk, ebiggers@google.com,
peterz@infradead.org, ying.huang@intel.com, gpiccoli@igalia.com,
mchehab+huawei@kernel.org, Jason@zx2c4.com, daniel@iogearbox.net,
robh@kernel.org, wangqing@vivo.com, prestwoj@gmail.com,
dsahern@kernel.org, stephen.s.brennan@oracle.com
Subject: Re: [RFC 1/1] kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiers
Date: Fri, 1 Apr 2022 14:35:03 -0700 [thread overview]
Message-ID: <YkdwB4Yh0hNgEyOa@bombadil.infradead.org> (raw)
In-Reply-To: <20220401202300.12660-2-alejandro.j.jimenez@oracle.com>
On Fri, Apr 01, 2022 at 04:23:00PM -0400, Alejandro Jimenez wrote:
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 830aaf8ca08e..8e0be72b5fba 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2339,6 +2339,13 @@ static struct ctl_table kern_table[] = {
> .extra2 = SYSCTL_INT_MAX,
> },
> #endif
> + {
> + .procname = "crash_kexec_post_notifiers",
> + .data = &crash_kexec_post_notifiers,
> + .maxlen = sizeof(int),
> + .mode = 0644,
> + .proc_handler = proc_dobool,
> + },
> { }
Please don't add any new sysctls to this file anymore. See
sysctl-testing which trims its uses. Plenty of examples for you
to see what to do, hopefully [0].
[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-testing
Luis
next prev parent reply other threads:[~2022-04-01 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 20:22 [RFC 0/1] Add sysctl entry for controlling crash_kexec_post_notifiers Alejandro Jimenez
2022-04-01 20:23 ` [RFC 1/1] kernel/sysctl: Add sysctl entry for crash_kexec_post_notifiers Alejandro Jimenez
2022-04-01 21:35 ` Luis Chamberlain [this message]
2022-04-02 14:01 ` [RFC 0/1] Add sysctl entry for controlling crash_kexec_post_notifiers Guilherme G. Piccoli
2022-04-04 20:43 ` Alejandro Jimenez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkdwB4Yh0hNgEyOa@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=alejandro.j.jimenez@oracle.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dsahern@kernel.org \
--cc=ebiggers@google.com \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mchehab+huawei@kernel.org \
--cc=peterz@infradead.org \
--cc=prestwoj@gmail.com \
--cc=robh@kernel.org \
--cc=stephen.s.brennan@oracle.com \
--cc=wangqing@vivo.com \
--cc=ying.huang@intel.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).