linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yusuf Khan <yusisamerican@gmail.com>
Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com,
	mikelley@microsoft.com, mst@redhat.com, javier@javigon.com,
	arnd@arndb.de, will@kernel.org, axboe@kernel.dk,
	Christoph Grenz <christophg+lkml@grenz-bonn.de>
Subject: Re: [PATCH v10 1/3] drivers: ddcci: add drivers for DDCCI
Date: Mon, 4 Apr 2022 06:58:26 +0200	[thread overview]
Message-ID: <Ykp68hTQF1a8EpTj@kroah.com> (raw)
In-Reply-To: <20220403230850.2986-2-yusisamerican@gmail.com>

On Sun, Apr 03, 2022 at 04:08:49PM -0700, Yusuf Khan wrote:
> This patch adds the main DDCCI driver. This interfaces with I2C to allow the
> kernel to communicate with DDCCI supporting monitors, it exports a chardev
> and sysfs interface for userspace.

Where is the Documentation/ABI/ entries for the sysfs code, and where is
the userspace code that uses the chardev interface?  And why chardev?

This text says _what_ you are doing, but not _why_ you are doing it.

thanks,

greg k-h

  reply	other threads:[~2022-04-04  4:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-03 23:08 [PATCH v10 0/3] drivers: ddcci: add drivers for DDCCI Yusuf Khan
2022-04-03 23:08 ` [PATCH v10 1/3] " Yusuf Khan
2022-04-04  4:58   ` Greg KH [this message]
2022-04-04 13:11   ` [PATCH] drivers: ddcci: fix platform_no_drv_owner.cocci warnings kernel test robot
2022-04-04 13:14   ` [PATCH v10 1/3] drivers: ddcci: add drivers for DDCCI kernel test robot
2022-04-03 23:08 ` [PATCH v10 2/3] " Yusuf Khan
2022-04-03 23:08 ` [PATCH v10 3/3] " Yusuf Khan
2022-04-03 23:34 ` [PATCH v10 0/3] " Randy Dunlap
2022-04-04  4:57 ` Greg KH
2022-04-04 11:10 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ykp68hTQF1a8EpTj@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=christophg+lkml@grenz-bonn.de \
    --cc=jasowang@redhat.com \
    --cc=javier@javigon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mst@redhat.com \
    --cc=will@kernel.org \
    --cc=yusisamerican@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).